Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect `by column should not have null values in 'rolling by' expression` error #16246

Closed
2 tasks done
MarcoGorelli opened this issue May 15, 2024 · 0 comments · Fixed by #16247
Closed
2 tasks done

Incorrect `by column should not have null values in 'rolling by' expression` error #16246

MarcoGorelli opened this issue May 15, 2024 · 0 comments · Fixed by #16247
Assignees
@MarcoGorelli
Labels
bug Something isn't working P-low Priority: low python Related to Python Polars

Comments

@MarcoGorelli
Copy link
Collaborator

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl
from datetime import date, datetime

import polars as pl

df = pl.concat([pl.DataFrame({'a': [datetime(2020, 1, 1)], 'b': [1]}), pl.DataFrame({'a': [datetime(2021, 1, 1)]
   , 'b': [1]})], rechunk=False)
print(df.select(pl.col('b').rolling_max_by('a', '1d')))

Log output

Traceback (most recent call last):
  File "/home/marcogorelli/scratch/t.py", line 8, in <module>
    df.select(pl.col('b').rolling_max_by('a', '1d'))
  File "/home/marcogorelli/scratch/.venv/lib/python3.11/site-packages/polars/dataframe/frame.py", line 8137, in select
    return self.lazy().select(*exprs, **named_exprs).collect(_eager=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/marcogorelli/scratch/.venv/lib/python3.11/site-packages/polars/lazyframe/frame.py", line 1816, in collect
    return wrap_df(ldf.collect(callback))
                   ^^^^^^^^^^^^^^^^^^^^^
polars.exceptions.ComputeError: `by` column should not have null values in 'rolling by' expression
(.venv) marcogorelli@DESKTOP-U8OKFP3:~/scratch$ POLARS_VERBOSE=1 python t.py
Traceback (most recent call last):
  File "/home/marcogorelli/scratch/t.py", line 8, in <module>
    df.select(pl.col('b').rolling_max_by('a', '1d'))
  File "/home/marcogorelli/scratch/.venv/lib/python3.11/site-packages/polars/dataframe/frame.py", line 8137, in select
    return self.lazy().select(*exprs, **named_exprs).collect(_eager=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/marcogorelli/scratch/.venv/lib/python3.11/site-packages/polars/lazyframe/frame.py", line 1816, in collect
    return wrap_df(ldf.collect(callback))
                   ^^^^^^^^^^^^^^^^^^^^^
polars.exceptions.ComputeError: `by` column should not have null values in 'rolling by' expression

Issue description

there's no nulls

Expected behavior

shape: (2, 1)
┌─────┐
│ b   │
│ --- │
│ i64 │
╞═════╡
│ 1   │
│ 1   │
└─────┘

Installed versions

--------Version info---------
Polars:               0.20.26
Index type:           UInt32
Platform:             Linux-5.15.146.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
Python:               3.11.9 (main, Apr  6 2024, 17:59:24) [GCC 11.4.0]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          3.0.0
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               2024.3.1
gevent:               <not installed>
hvplot:               0.9.2
matplotlib:           3.8.4
nest_asyncio:         1.6.0
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.0
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
pyxlsb:               <not installed>
sqlalchemy:           <not installed>
torch:                <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@MarcoGorelli MarcoGorelli added bug Something isn't working python Related to Python Polars needs triage Awaiting prioritization by a maintainer labels May 15, 2024
@MarcoGorelli MarcoGorelli self-assigned this May 15, 2024
@MarcoGorelli MarcoGorelli added P-low Priority: low and removed needs triage Awaiting prioritization by a maintainer labels May 15, 2024
@MarcoGorelli MarcoGorelli mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoGorelli MarcoGorelli

Labels
bug Something isn't working P-low Priority: low python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
No milestone
1 participant
@MarcoGorelli