Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node v18 LTS #1554

Open
ajohn25 opened this issue Jan 18, 2023 · 2 comments · May be fixed by #1600
Open

Upgrade to Node v18 LTS #1554

ajohn25 opened this issue Jan 18, 2023 · 2 comments · May be fixed by #1600
Assignees
@lediur
Labels
build: ci ♾️ Continuous integration build: deployment ⚙️ Related to deploying Spoke build: docker 🐳 Docker-related build changes

Comments

@ajohn25
Copy link
Contributor

ajohn25 commented Jan 18, 2023

Likely requires upgrading some other packages. See current warning
image
@ajohn25 ajohn25 added build: ci ♾️ Continuous integration build: docker 🐳 Docker-related build changes build: deployment ⚙️ Related to deploying Spoke labels Jan 18, 2023
@lediur
Copy link
Contributor

lediur commented May 10, 2023

Does Spoke plan to use ts-jest in the future? I notice that Spoke currently doesn't use TypeScript in its testing, but a common way to run tests (ts-jest) has some known memory leak issues when run on Node versions above 16.10.0.

See the following issues:

There are some possible workarounds with using custom jest runtimes (either @swc/jest or https://github.com/reside-eng/jest-runtime. I believe if we upgrade to Jest 29 we can also resolve the issue with --workerIdleMemoryLimit.

@lediur
Copy link
Contributor

lediur commented May 10, 2023

I'll start work on this and note any issues that I run into here.

@lediur lediur self-assigned this May 10, 2023
@lediur lediur linked a pull request May 10, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lediur lediur

Labels
build: ci ♾️ Continuous integration build: deployment ⚙️ Related to deploying Spoke build: docker 🐳 Docker-related build changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(node)!: update 16.14 -> 18.16 politics-rewired/Spoke
2 participants
@lediur @ajohn25