Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API to RxJS ^6.5.x #852

Closed
Stefie opened this issue Apr 23, 2019 · 2 comments · Fixed by #897
Closed

Update API to RxJS ^6.5.x #852

Stefie opened this issue Apr 23, 2019 · 2 comments · Fixed by #897

Comments

@Stefie
Copy link
Contributor

Stefie commented Apr 23, 2019

combineLatest and to are deprecated since RxJS 6.5.0 and the build is failing when once we're updating to the latest version. https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#650-2019-04-23

The two are mostly used on api-derive, but also in SubmittableExtrinsics

ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/accounts/idAndIndex.ts:44:14 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/fees.ts:15:13 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/validatingBalance.ts:18:12 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/validatingBalances.ts:17:9 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/votingBalance.ts:21:13 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/votingBalance.ts:22:13 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/votingBalance.ts:26:13 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/votingBalances.ts:16:9 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/votingBalances.ts:17:9 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/balances/votingBalancesNominatorsFor.ts:21:13 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/chain/bestNumberLag.ts:27:5 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/chain/getHeader.ts:32:11 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/chain/subscribeNewHead.ts:33:12 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/chain/subscribeNewHead.ts:34:13 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/chain/subscribeNewHead.ts:40:17 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/democracy/referendumInfos.ts:18:9 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/democracy/referendumVotesFor.ts:20:9 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/democracy/referendumVotesFor.ts:21:11 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/democracy/referendums.ts:16:6 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/democracy/referendums.ts:27:13 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/democracy/votes.ts:15:9 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/session/eraLength.ts:15:6 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/session/eraProgress.ts:16:6 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/session/sessionProgress.ts:16:5 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/staking/controllers.ts:28:11 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/staking/controllers.ts:29:13 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api-derive/src/util/drr.spec.ts:12:5 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api/src/SubmittableExtrinsic.ts:88:14 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)`
ERROR: /home/travis/build/polkadot-js/api/packages/api/src/SubmittableExtrinsic.ts:93:12 - combineLatest is deprecated: Pass arguments in a single array instead `combineLatest([a, b, c])`
ERROR: /home/travis/build/polkadot-js/api/packages/api/src/SubmittableExtrinsic.ts:191:19 - of is deprecated: use {@link scheduled} instead `scheduled([a, b, c], scheduler)````
@Stefie Stefie added this to To Do in @polkadot{.js} via automation Apr 23, 2019
@Stefie
Copy link
Contributor Author

Stefie commented Apr 25, 2019

The of deprecation warning seems to be bug. ReactiveX/rxjs#4723
There is a PR that fixes it ReactiveX/rxjs#4724.

So it's only combineLatest

@jacogr jacogr added -size-xs and removed -size-s labels Apr 29, 2019
@polkadot{.js} automation moved this from To Do to Done May 13, 2019
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants