Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific core mask is displayed incorrectly on PJS apps #10343

Open
seadanda opened this issue Mar 8, 2024 · 6 comments
Open

Specific core mask is displayed incorrectly on PJS apps #10343

seadanda opened this issue Mar 8, 2024 · 6 comments

Comments

@seadanda
Copy link

seadanda commented Mar 8, 2024

It was pointed out that this is just an incorrect representation of the core mask b01010101010101010101010101010101010101010101010101010101010101010101010101010101, which equates to UUUUUUUUUU in Unicode.
When a region is interlaced 50% we end up with this core mask. This will happen quite often and should be displayed in a way that is consistent with any other core mask.

It appears that apps tries to decode it as UTF-8 before (correctly) decoding it as hex or an 80 bit binary string. It should not try to decode this field as UTF-8.

  • Please tell us about your environment:
    Easily reproduced by checking the Rococo Coretime Chain state broker.regions and ctrl+F UUUUUUUUUU, comparing to the other regions and how they are displayed.

    • Version:
      Polkadot parachain v4.0.0
      api v10.11.2
      apps v0.133.2-119

    • Environment:
      Browser

@Szegoo
Copy link

Szegoo commented Mar 8, 2024

This issue is related to the PJS API repository, as it arises during the attempt to format regionId using toHuman()

@seadanda
Copy link
Author

seadanda commented Mar 8, 2024

Maybe a code owner could move this issue to that repo

@TarikGul
Copy link
Member

This is in the queue to check further on Thursday! Thanks for the patience.

@TarikGul
Copy link
Member

So I looked into this (not to deep as its been a long day). But the console is logging:

params: initValue: No default value for type PalletBrokerCoreMask from {"info":10,"name":"mask","type":"PalletBrokerCoreMask"}, using defaults

params: findComponent: No pre-defined component for type PalletBrokerCoreMask from Plain: {"info":10,"name":"mask","type":"PalletBrokerCoreMask"}

Which is a good start. I'll continue looking into this in the morning.

@TarikGul
Copy link
Member

Ahh nvm the above warnings i posted have to do with the params.... Not connected to the above issue.

@TarikGul
Copy link
Member

Sorry for the little delay. This is a bit deeper than I thought, but it goes all the way to the common repo. Basically the storage key for mask is valid ascii which is interpreted in the api as that here.

Looking into a more specific solution now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants