Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Tray] Reduce sensitivity or remove the ability to un-favorite apps by dragging #358

Closed
git-f0x opened this issue Apr 18, 2024 · 9 comments · Fixed by #444
Closed

[App Tray] Reduce sensitivity or remove the ability to un-favorite apps by dragging #358

git-f0x opened this issue Apr 18, 2024 · 9 comments · Fixed by #444
Milestone

Comments

@git-f0x
Copy link
Contributor

git-f0x commented Apr 18, 2024

The apps can be removed when the intent is to launch an app, by just accidentally slightly moving the cursor while clicking.
I would personally prefer if dragging was only used for rearranging apps (e.g. when an app is held, the cursor can be moved anywhere on the screen, and the app would rearrange accordingly, similar to scroll bar behavior).
This way, dragging within the App List would only be used for rearranging apps, while the context menu would be used to un-favorite an app.

@wash2
Copy link
Contributor

wash2 commented Apr 19, 2024

I think reducing sensitivity would be fine.

@ahoneybun ahoneybun changed the title [App List] Reduce sensitivity or remove the ability to un-favorite apps by dragging [App Tray] Reduce sensitivity or remove the ability to un-favorite apps by dragging May 14, 2024
@WatchMkr WatchMkr added this to the alpha 1 milestone May 14, 2024
@WatchMkr
Copy link

This was a clear issue while observing a new user move to COSMIC.

@wash2
Copy link
Contributor

wash2 commented May 14, 2024

https://github.com/pop-os/cosmic-applets/compare/app-list-drag?expand=1 should make it less sensitive. Does it feel like there are fewer accidental grabs?

@git-f0x
Copy link
Contributor Author

git-f0x commented May 14, 2024

It is a bit better, but I can still sometimes un-favorite unintentionally.
For accessibility reasons (since people can possibly have trouble with letting go of a mouse button quickly), it might be better to only be able to un-favorite apps using the context menu, and would make it easier to rearrange apps when not having to worry about removing them while dragging (e.g. rearranging apps on a panel without gaps can un-favorite apps when the cursor approaches the screen edge).
For reference, KDE Plasma and Windows don't allow removing an app from the taskbar by dragging it away.
And personally, it would feel nicer for favorites to be more "locked", since favoriting and un-favoriting is probably a rare action.

@wash2
Copy link
Contributor

wash2 commented May 14, 2024

Ok, thanks for testing it. I think then that it would be good to allow disabling DnD via the app-tray config.

@git-f0x
Copy link
Contributor Author

git-f0x commented May 14, 2024

Would it be possible to keep e.g. DnD from the App Library to the App Tray, but just not allow un-favoriting with DnD?

@wash2
Copy link
Contributor

wash2 commented May 14, 2024

Ya, I don't think that it being a drop target is an issue. I Think it will probably still allow un-favoriting by default with DnD, but I'll make that configurable.

@git-f0x
Copy link
Contributor Author

git-f0x commented May 14, 2024

Thanks!
I suppose user feedback closer to release will tell which would be the preferred default.
Should I close this?

@wash2
Copy link
Contributor

wash2 commented May 15, 2024

I'll close it after I make it configurable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Alpha 1 Complete
Development

Successfully merging a pull request may close this issue.

3 participants