Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory symlinks are ignored while searching for desktop files #1

Open
reddraggone9 opened this issue Jan 13, 2022 · 0 comments
Open

Comments

@reddraggone9
Copy link

if file_type.is_dir() {
self.directories_to_walk.push((path_src.clone(), path));
} else if (file_type.is_file() || file_type.is_symlink())
&& path.extension().map_or(false, |ext| ext == "desktop")

This follows symlinks to files, but not symlinks to directories. Is that an intentional decision? If not would you be interested in a pull request to add support for recursing through symlinked directories? I can see where a naive implementation would result in an infinite loop if a bad symlink was encountered, so that would need to be handled with care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant