Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy "fixed" not working fine for popper@2 #1115

Closed
wszydlak opened this issue May 28, 2020 · 1 comment · Fixed by #1123
Closed

Strategy "fixed" not working fine for popper@2 #1115

wszydlak opened this issue May 28, 2020 · 1 comment · Fixed by #1123
Labels
bug Something is not working.

Comments

@wszydlak
Copy link
Contributor

According to: #1035 I want to continue this topic, don't know why you said that my tone is over the top, but I'm sorry if I offended you.

But to continue I sent you examples, potencial function which made it working better in popper@1 and polite asked you to reopen issue, due to bug in popper@2

@wszydlak wszydlak added bug Something is not working. NEEDS: triage labels May 28, 2020
@atomiks
Copy link
Collaborator

atomiks commented May 29, 2020

You can create a PR that checks for the properties that create a containing block on parents and see if it doesn't kill perf, or add an unstable_getOffsetParent option to Popper that allows users to specify their own getOffsetParent DOM util so they can specify a custom element or detect "containing blocks" which .offsetParent can't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants