Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect containing block #1123

Merged
merged 1 commit into from Jun 8, 2020

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Jun 6, 2020

Closes #1115

@rollingversions
Copy link

rollingversions bot commented Jun 6, 2020

Change Log for @popperjs/core (2.4.0 → 2.4.1)

Bug Fixes

Edit changelog

@ptu14
Copy link
Contributor

ptu14 commented Jun 6, 2020

This solution helps with my problem which I tried to solve in #1120 . I tested this solution in various scenarios and it works very well.

@FezVrasta FezVrasta merged commit f2b619b into floating-ui:master Jun 8, 2020
@FezVrasta FezVrasta deleted the fix/containing-block branch June 8, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strategy "fixed" not working fine for popper@2
3 participants