Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typecript types to npm build #593

Merged
merged 1 commit into from Jul 17, 2018
Merged

Conversation

epicallan
Copy link

No description provided.

@FezVrasta
Copy link
Member

They are already in the build:
https://unpkg.com/popper.js@1.14.1/index.d.ts

@FezVrasta FezVrasta closed this Apr 3, 2018
@JeroenVinke
Copy link

@FezVrasta I might be wrong, but I believe the index.d.ts file is missing for the tooltip.js package. https://unpkg.com/tooltip.js@1.2.0/index.d.ts does not exist while https://unpkg.com/tooltip.js@1.2.0/package.json does reference it. Could you reevaluate this PR? Let me know if there is anything I can do to help

@FezVrasta FezVrasta reopened this Jul 17, 2018
@FezVrasta
Copy link
Member

Right, I mixed up things :-)

@FezVrasta FezVrasta merged commit 0642ce0 into floating-ui:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants