fix(computeStyle): correctly calculate bottom when x="top" and `rig…
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When testing this I noticed that the reproducer in #585 had a couple of extras in it that werent causing the bug. I found this bug appears when:
|
|
looks like the tests are failing in IE10, ill try to take a look at that later today |
…ht` when y="left" Fixes #585
|
Fixed the unit tests, everything seems good now |
|
thanks! |
|
Hey @FezVrasta any idea when this change will be released? Id love to start using it in my project |
|
As soon I have some free time I'll publish it, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ht` when y="left"
Fixes #585