We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In our code we had an issue where we passed max: undefined when creating a Postgres instance, expecting that it would fall back to the default 10.
max: undefined
However, the undefined value seems to overwrite the default max: 10 due to this line: https://github.com/porsager/postgres/blob/master/src/index.js#L472
undefined
max: 10
Then, due to this line, the array resolves to [undefined] and therefore only a single connection will be created. https://github.com/porsager/postgres/blob/master/src/index.js#L65
[undefined]
If max: undefined is passed then perhaps the default 10 needs to take precedence.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In our code we had an issue where we passed
max: undefinedwhen creating a Postgres instance, expecting that it would fall back to the default 10.However, the
undefinedvalue seems to overwrite the defaultmax: 10due to this line:https://github.com/porsager/postgres/blob/master/src/index.js#L472
Then, due to this line, the array resolves to
[undefined]and therefore only a single connection will be created.https://github.com/porsager/postgres/blob/master/src/index.js#L65
If
max: undefinedis passed then perhaps the default 10 needs to take precedence.The text was updated successfully, but these errors were encountered: