Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Retrieve More Than 1000 Slack Users #184

Open
zollo opened this issue Oct 23, 2019 · 5 comments
Open

Can't Retrieve More Than 1000 Slack Users #184

zollo opened this issue Oct 23, 2019 · 5 comments
Assignees
Labels
pinned Prevent closing if stale

Comments

@zollo
Copy link

zollo commented Oct 23, 2019

Expected Behavior

PoshBot should be able to work with any number of users in the Slack workspace.

Current Behavior

PoshBot can only retrieve 1000 users.

Possible Solution

This is likely due to incorrect pagination via the Slack API.

Steps to Reproduce (for bugs)

Launch PoshBot and connect to a Slack workspace with > 1000 users.

Context

With the 1000 user limit, most users are not able to leverage the bot, we see errors that the user can't be identified. I'm in several Slack spaces with >1000 users so this would be a breaking issue.

Your Environment

PowerShell 5.1 on Windows Server 2019, same issue on Windows 10 1903.

@kilasuit
Copy link

kilasuit commented Oct 23, 2019

This is likely a PSSlack issue that is just being surfaced in PoshBot

Can you try using PSSlack and getting all the users in your slack instance via that?

@kilasuit
Copy link

Looking into this as mentioned it is an issue with PSSlack / the actual Slack API implementation for returning users

@zollo
Copy link
Author

zollo commented Oct 23, 2019

Confirmed - this is not a PoshBot issue! Get-SlackUser only returns 1000 users.

@devblackops
Copy link
Member

Probably an straightforward fix if someone wants to add paging support similarly to how I did it for channels. RamblingCookieMonster/PSSlack#90. We pin to a specific version of PSSlack so once that is released, we can bump the dependency and have it in the v0.12.0 release (which adds Discord support as well).

@stale
Copy link

stale bot commented Dec 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 22, 2019
@stale stale bot closed this as completed Jan 5, 2020
@devblackops devblackops added the pinned Prevent closing if stale label Jan 13, 2020
@devblackops devblackops self-assigned this Jan 13, 2020
@devblackops devblackops reopened this Jan 13, 2020
@stale stale bot removed the stale label Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Prevent closing if stale
Projects
None yet
Development

No branches or pull requests

3 participants