Add support for an autoprefixer config in package.json and/or a seperate config file #1257

Dan503 · 2019-10-21T02:58:06Z

I am working on a create-react-app project at the moment and I can't figure out how to enable Autoprefixer CSS Grid translations.

I can't use control comments because we are using Material UI CSS in JS. It doesn't really provide a way to add comments to the output CSS
https://material-ui.com/styles/basics/#higher-order-component-api

creat-react-app is intended to be a simple zero config React solution that hides all of the ugly webpack stuff from the author.

It is possible to make all that webpack stuff editable (and thus making it possible to edit the autoprefixer settings) by ejecting the project, but this is not a preferable option.

What I would like to do instead is define my custom autoprefixer settings in a file in the root folder or as an option in the package.json file (think like how Browsers List works).

This would theoretically allow for custom Autoprefixer configurations in projects like create-react-app and Angular that are not built to give their users full configuration control.

Chun-Lin · 2019-10-21T03:07:15Z

Have the same problem here. I'm using CSS-in-JS solutions to style my components in the project, and I don't really want to eject the project. What I want is to add config to the package.json.

ai · 2019-10-21T12:42:42Z

Adding the whole config for one feature could be a tricky thing (especially, because finding config will slow down Autoprefixer for all users).

But I understand that we need a solution for grid: 'autoplace', CSS-in-JS and CRA problem.

Can we use .env file and set the global environment variable?

Dan503 · 2019-10-21T12:53:11Z

Adding it to a seperate file might be a bit expensive since you would need to look for the file, check it exists, if it does, read the file, parse it, apply the settings from it.

Adding it through package.json wouldn't be that bad though would it? It is basically just a require('../../package.json') statement isn't it? That is pretty efficient and won't cause much slow down.

ai · 2019-10-21T13:43:06Z

It is basically just a require('../../package.json') statement isn't it?

Nope. You need to walk through the path to find project root package.json. Browserslist does it already, but we do not have API to pass it from Browserslist to Autoprefixer (and this API could be hard to make since Browserslist could read config from a different location).

This is why I think the environment variables process.env.AUTOPREFIXER_GRID is the best option. Easy to add and fast to read.

You can set it in your package.json scripts by AUTOPREFIXER_GRID=autoplace react-script build.

Will it work in your case?

Dan503 · 2019-10-21T13:48:38Z

That might work.

It is possible to set more than one environment variable right?

Something like AUTOPREFIXER_GRID=autoplace environment=development react-script build?

I would prefer the environment variable not be all caps unless it is following a common convention by doing that.

ai · 2019-10-21T13:50:55Z

I would prefer the environment variable not be all caps unless it is following a common convention by doing that.

It seems like to is the UNIX convention to have it uppercases. We already use uppercases variables in Browserslist.

It is possible to set more than one environment variable right?

Yeap.

Dan503 · 2019-10-21T13:52:14Z

Sounds like a good solution to me then 😊

ai · 2019-10-22T15:25:57Z

Done 24b9aed

I will release it when we will speed up Browserslist #1256

Dan503 · 2019-10-24T07:06:44Z

Was this released in 9.6.5 as well?

Maybe add it to the release notes.

ai · 2019-10-24T07:08:28Z

@Dan503 nope. This feature will be in 9.7 today.

ai · 2019-10-24T13:13:36Z

Released in 9.7

Dan503 · 2019-10-24T13:14:58Z

I'll give it a try tomorrow morning and see if it works 😁

Chun-Lin · 2019-11-01T08:14:20Z

I installed the newest browserslist to my project, the version is 9.7.1, and set the build script like "AUTOPREFIXER_GRID=autoplace react-scripts build", but css grid still cannot be prefixed in styled-components. Below is the example codes.

const Grid = styled.div`
  /* autoprefixer grid: autoplace */
  display: grid;
  height: 600px;
  grid-gap: 20px;
  grid-template-columns: 50% 2fr 1fr 1fr;
  grid-template-rows: 1fr 2fr 1fr 1fr;
`

CSS-in-JS solution is working in this version by using environment variables?

Dan503 · 2019-11-01T08:18:12Z

autoprefixer is the npm package that you need to update.

If you are using the environment variable then /* autoprefixer grid: autoplace */ should not be needed.

Dan503 · 2019-11-01T08:39:40Z

I can confirm that the environment variable works

These are the steps I took:

npm i create-react-app -g (not necesary if you have used create-react-app before)
create-react-app test-app
cd test-app
Added display: grid; to .App { ... } in test-app/src/App.css
Added user-select: none; as well to make sure Autoprefixer is actually running
npm i autoprefixer@latest -D
Under "browserslist" > "development" in package.json, I added "last 1 ie version"
I updated "scripts" in package.json to the following:

"scripts": {
    "start": "set AUTOPREFIXER_GRID=autoplace && react-scripts start",
    "build": "set AUTOPREFIXER_GRID=autoplace && react-scripts build",
    "test": "set AUTOPREFIXER_GRID=autoplace && react-scripts test",
    "eject": "react-scripts eject"
},

run npm start

It compiles cleanly and it adds the CSS Grid prefixes as expected 😊

Chun-Lin · 2019-11-01T09:01:26Z

Yeah, add display:grid to App.css works for me, but when I tried to styling App.js by using styled-components, the CSS Grid prefixes are not prefixed.

Dan503 · 2019-11-01T09:05:24Z

It must not be getting the environment variable passed into it :/

You might need to raise this as an issue against Styled Components, I'm not sure there is anything Autoprefixer can do about your use case 🙁

Chun-Lin · 2019-11-01T09:27:16Z

I just found that even in App.css the CSS Grid prefixes are not working.

The steps I took are:

npx create-react-app test-app
cd test-app
Added display: grid; to .App { ... } in test-app/src/App.css
yarn add autoprefixer@latest -D
Added user-select: none; as well to make sure Autoprefixer is actually running
Under "browserslist" > "development" and "browserslist" > "production" in package.json, I added "last 1 ie version"
set "scripts" in package.json like, "start": "set AUTOPREFIXER_GRID=autoplace && react-scripts start"
run yarn start

user-select is perfectly prefixed, but CSS Grid cannot be prefixed, unless I add /* autoprefixer grid: autoplace */ on top of App.css, and CSS-in-JS (styled-components) cannot be prefixed in both ways.

Dan503 · 2019-11-01T10:35:08Z

Wierd, I'm not sure why it isn't working for you :/

My package.json file:

{
	"name": "test-app",
	"version": "0.1.0",
	"private": true,
	"dependencies": {
		"autoprefixer": "^9.7.1",
		"react": "^16.11.0",
		"react-dom": "^16.11.0",
		"react-scripts": "3.2.0"
	},
	"scripts": {
		"start": "set AUTOPREFIXER_GRID=autoplace && react-scripts start",
		"build": "set AUTOPREFIXER_GRID=autoplace && react-scripts build",
		"test": "set AUTOPREFIXER_GRID=autoplace && react-scripts test",
		"eject": "react-scripts eject"
	},
	"eslintConfig": {
		"extends": "react-app"
	},
	"browserslist": {
		"production": [
			">0.2%",
			"not dead",
			"not op_mini all"
		],
		"development": [
			"last 1 chrome version",
			"last 1 firefox version",
			"last 1 safari version",
			"last 1 ie version"
		]
	}
}

Dan503 · 2019-11-01T10:43:04Z

I'm on Windows. I'm wondering if this is a platform issue 🤔

Chun-Lin · 2019-11-01T12:44:15Z

I have almost the same package.json as yours, just add "last 1 ie version" to production.

The CSS code

Chrome Devtool

Chun-Lin · 2019-11-01T12:46:26Z

I don't have Windows to test right now, but I'll try to find a Windows PC to see the result and let you know tomorrow.

Thanks for your help @Dan503 :)

Dan503 · 2019-11-01T12:52:18Z

If this method only works on Windows then it is still a bug, but maybe something that should be opened as a new ticket since the work of applying the actual environment variable to Autoprefixer is done.

Chun-Lin · 2019-11-04T02:46:27Z

@Dan503, I've tested both Windows and Mac with the same codebase, looks like CSS grid prefixed perfectly in App.css on Windows 10, but it doesn't work on Mac, and styled-components doesn't work on both platforms.

ai · 2019-11-04T02:48:53Z

@Chun-Lin does styled-components has Autoprefixer support?

It takes CSS parser to the client-side bundle (instead of compiling CSS once during deploy).

Chun-Lin · 2019-11-04T03:06:54Z

@ai you are right, it was my fault. Looks like it doesn't support autoprefixer because it prefixes codes during runtime. It uses stylis to prefix CSS, butstylis doesn't support CSS grid prefixes for now.

ai · 2019-11-04T03:11:33Z

@Chun-Lin you can try Astroturf or Linaria. It is zero-runtime CSS-in-JS. In addition to full Autoprefixer support, they also have better performance since they compile CSS only once during runtime.

Dan503 · 2019-11-04T03:13:45Z

I think the problem on Mac is that the environment variables aren't getting passed into React.

If you can figure out how to get React to read the environment variable on Mac then we can update the documentation. I don't have access to a Mac so I'm not much help.

Chun-Lin · 2019-11-04T05:31:13Z

Thanks @ai, I'll try to promote another CSS-in-JS solution when the team projects need CSS GRID :)

Chun-Lin · 2019-11-04T05:51:26Z

@Dan503, I used the original script "start": "AUTOPREFIXER_GRID=autoplace react-scripts start", and then it worked in App.css on Mac, but it doesn't work on Windows PC. I think the problem is the differences of cmd environment on both platforms.

An easy solution is to install cross-env and update the script to "start": "cross-env AUTOPREFIXER_GRID=autoplace react-scripts start", then that works on both platforms as I've tested on both of them.

Dan503 · 2019-11-04T10:28:33Z

I'll try to promote another CSS-in-JS solution when the team projects need CSS GRID :)

I think you should log a ticket against styled components asking for Post CSS compatibility support.

Chun-Lin · 2019-11-04T10:43:20Z

I think you should log a ticket against styled components asking for Post CSS compatibility support.

There is an issue about switching prefixer from stylis to autoprefixer.
styled-components/styled-components#1184

Looks like they choose stylis for better performance, but since autoprefixer 9.7.x performance has been improved, I should highlight it again.

ai · 2019-11-04T11:56:47Z

There is an issue about switching prefixer from stylis to autoprefixer

Don't forget that stylis in SC is slower than Autoprefixer in Astroturf/Linaria. Because of architecture, SC must compile CSS and add prefixes on any style changes on client side. Zero runtime CSS-in-JS does it only once during the deploy.

The main problem of SC, that you need to put all you CSS tools to client side bundle. JS bundle size is very critical for performance (because compiling and executing 100 KB of JS is much slower that downloading the same 100 KB of data and can't be cached). As result, it will be very bar to put Can I Use data to client side bundle. SC can't switch to Autoprefixer because of their architecture.

Chun-Lin · 2019-11-05T02:08:42Z

Don't forget that stylis in SC is slower than Autoprefixer in Astroturf/Linaria. Because of architecture, SC must compile CSS and add prefixes on any style changes on client side. Zero runtime CSS-in-JS does it only once during the deploy.

The main problem of SC, that you need to put all you CSS tools to client side bundle. JS bundle size is very critical for performance (because compiling and executing 100 KB of JS is much slower that downloading the same 100 KB of data and can't be cached). As result, it will be very bar to put Can I Use data to client side bundle. SC can't switch to Autoprefixer because of their architecture.

@ai you are right, I think they won't switch to autoprefixer because SC is a runtime CSS-in-JS that bigger bundle size may hurt the performance.
#1257 (comment)

I think for now a workaround way to write CSS grid in styled-components is to use autoprefixer online service to convert the code.

ai closed this as completed Oct 22, 2019

snyk-bot mentioned this issue Nov 2, 2019

[Snyk] Upgrade autoprefixer from 9.6.1 to 9.7.0 noprotocol/gulp-noprotocol#9

Open

Dan503 mentioned this issue Nov 4, 2019

Updating environment variable documentation to include multi-platform support #1262

Merged

snyk-bot mentioned this issue Jan 30, 2020

[Snyk] Upgrade autoprefixer from 9.6.1 to 9.7.3 UBCCM/UBC-DEF#49

Open

snyk-bot mentioned this issue Feb 23, 2020

[Snyk] Upgrade autoprefixer from 9.5.1 to 9.7.4 saurabharch/linkpreview#5

Open

vpetersson mentioned this issue Mar 6, 2020

[Snyk] Upgrade autoprefixer from 9.4.7 to 9.7.4 WoTTsecurity/api#758

Merged

This was referenced Mar 13, 2020

[Snyk] Upgrade autoprefixer from 9.4.2 to 9.7.4 DmytroSkrypnyk/test_bootstrap#7

Open

[Snyk] Upgrade autoprefixer from 9.6.0 to 9.7.4 BeAPI/beapi-frontend-framework#95

Merged

This was referenced Mar 20, 2020

[Snyk] Upgrade autoprefixer from 7.1.6 to 9.7.4 lwojcik/sc2pte-panel-frontend#76

Closed

[Snyk] Upgrade autoprefixer from 9.4.7 to 9.7.4 adamlaska/explosion-spaCy#5

Open

snyk-bot mentioned this issue Apr 15, 2020

[Snyk] Upgrade autoprefixer from 7.1.6 to 9.7.5 lwojcik/sc2pte-panel-frontend#113

Closed

This was referenced Apr 30, 2020

[Snyk] Upgrade autoprefixer from 7.1.6 to 9.7.6 lwojcik/sc2pte-panel-frontend#117

Closed

[Snyk] Upgrade autoprefixer from 9.1.5 to 9.7.6 Barnstorm-Online/barnstorm-cli#5

Open

Add support for an autoprefixer config in package.json and/or a seperate config file #1257

Add support for an autoprefixer config in package.json and/or a seperate config file #1257

Comments

Dan503 commented Oct 21, 2019 • edited Loading

Chun-Lin commented Oct 21, 2019

ai commented Oct 21, 2019

Dan503 commented Oct 21, 2019 • edited Loading

ai commented Oct 21, 2019

Dan503 commented Oct 21, 2019

ai commented Oct 21, 2019

Dan503 commented Oct 21, 2019

ai commented Oct 22, 2019

Dan503 commented Oct 24, 2019

ai commented Oct 24, 2019

ai commented Oct 24, 2019

Dan503 commented Oct 24, 2019

Chun-Lin commented Nov 1, 2019

Dan503 commented Nov 1, 2019

Dan503 commented Nov 1, 2019 • edited Loading

I can confirm that the environment variable works

Chun-Lin commented Nov 1, 2019

Dan503 commented Nov 1, 2019

Chun-Lin commented Nov 1, 2019 • edited Loading

Dan503 commented Nov 1, 2019

Dan503 commented Nov 1, 2019

Chun-Lin commented Nov 1, 2019

Chun-Lin commented Nov 1, 2019

Dan503 commented Nov 1, 2019

Chun-Lin commented Nov 4, 2019

ai commented Nov 4, 2019

Chun-Lin commented Nov 4, 2019 • edited Loading

ai commented Nov 4, 2019

Dan503 commented Nov 4, 2019

Chun-Lin commented Nov 4, 2019 • edited Loading

Chun-Lin commented Nov 4, 2019 • edited Loading

Dan503 commented Nov 4, 2019 • edited Loading

Chun-Lin commented Nov 4, 2019

ai commented Nov 4, 2019

Chun-Lin commented Nov 5, 2019

Dan503 commented Oct 21, 2019 •

edited

Loading

Dan503 commented Oct 21, 2019 •

edited

Loading

Dan503 commented Nov 1, 2019 •

edited

Loading

Chun-Lin commented Nov 1, 2019 •

edited

Loading

Chun-Lin commented Nov 4, 2019 •

edited

Loading

Chun-Lin commented Nov 4, 2019 •

edited

Loading

Chun-Lin commented Nov 4, 2019 •

edited

Loading

Dan503 commented Nov 4, 2019 •

edited

Loading