Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PostCSS 8 #147

Closed
jonnitto opened this issue Sep 16, 2020 · 2 comments · Fixed by #148
Closed

Compatibility with PostCSS 8 #147

jonnitto opened this issue Sep 16, 2020 · 2 comments · Fixed by #148

Comments

@jonnitto
Copy link

Currently, this plugin is not compatible with PostCSS 8, also because postcss-import is not compatible yet. It would be great if you could make these plugins compatible with the latest version.

@bcomnes
Copy link
Contributor

bcomnes commented Sep 22, 2020

Here is a link to the migration guide:

Looks easy to get things moved over preliminarily but I (just a user) unfortunately don't have time atm. Low hanging fruit for anyone else though:

https://evilmartians.com/chronicles/postcss-8-plugin-migration

@niksy
Copy link
Contributor

niksy commented Oct 20, 2020

Easiest way is to transfer everything to Once method. Do we want that or should we use more performant API? There’s only one walker defined (for declarations), and running tests on that walker produces some errors.

niksy added a commit to niksy/postcss-url that referenced this issue Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants