Option "--selector-filter" does not work for command "service list"

[rotscher]

The option "--selector-filter" does not work as the match is executed against labels and not against the selector field of the service:

// ServiceBySelector filters Services by Selector.
func ServiceBySelector(selector labels.Selector) FilterFunc {
	return func(s Service) bool {
                return selector.Matches(s.Labels)
	}
}

[rotscher]

Fix is trickier than first thought: do we fully support the label selector feature of Kubernetes (e.g. discovery service list --filter-selector="zone in (test,prod)") or is it only supported in a simple manner that means just zone=prod.

For the simple case a fix is already available (https://github.com/postfinance/discovery/tree/152-option-selector-filter-does-not-work-for-command-service-list) but this would not work for advanced selector usage.

Is the selector also a label of the service?

[rotscher]

filter-selector should support the label selector feature as in Kubernetes. Selection should be possible on target labels and/or server labels. The following changes are planned:

• filter-selector will be renamed to filter-label-selector
• a new option filter-server-selector will be provided