Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies have vulnerabilities #686

Open
Shepard opened this issue Sep 2, 2022 · 1 comment
Open

Dependencies have vulnerabilities #686

Shepard opened this issue Sep 2, 2022 · 1 comment

Comments

@Shepard
Copy link
Contributor

Shepard commented Sep 2, 2022

  • Platform: Windows 10 64 bit
  • Mercury Parser Version: 2.2.1
  • Node Version (if a Node bug): v16.16.0

Expected Behavior

No vulnerabilities reported by npm audit / yarn audit.

Current Behavior

Audit reports a bunch of vulnerabilities in dependencies of mercury-parser:

5 vulnerabilities found - Packages audited: 168
Severity: 1 Low | 3 Moderate | 1 High

Steps to Reproduce

  1. Create a node project.
  2. yarn add @postlight/mercury-parser (You already get a bunch of warnings about outdated and deprecated libraries here.)
  3. yarn audit

Detailed Description

I'm trying to keep our software free of vulnerabilities in order to reduce security risks for customers. It is good practice in my mind to update dependencies regularly to avoid any such issues.

Possible Solution

Would be great if these dependencies could be updated or replaced with others where necessary.

@johnholdun
Copy link
Contributor

johnholdun commented Sep 8, 2022

Thanks for noting this! I've just updated a lot of dependencies in #687. There's still one vulnerability listed for cheerio, which is both a critical piece of this project and one that is very hard to touch, in my experience. We have plans to come back to deal with cheerio soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants