Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable the watcher #336

Closed
tamasfe opened this issue Mar 5, 2024 · 0 comments · Fixed by #387
Closed

Add an option to disable the watcher #336

tamasfe opened this issue Mar 5, 2024 · 0 comments · Fixed by #387
Labels
✨ feature request a new feature request

Comments

@tamasfe
Copy link
Contributor

tamasfe commented Mar 5, 2024

Currently the vite plugin unconditionally starts a chokidar watcher that causes issues in CI environments:

  • inotify limits, CI machines often don't have the need to watch files thus have lower inotify limits that might not be enough
  • in some cases the watcher might cause vitest to hang, I haven't confirmed this but I've found that removing the plugin would solve the issue

A simple { watch: false } exposed as an option to the plugin could be enough that would disable file watching, also having !process.env.CI as a default value would also be reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature request a new feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants