Skip to content
This repository has been archived by the owner on Jun 10, 2023. It is now read-only.

Complete Cards #8

Open
6 tasks
posva opened this issue Feb 8, 2016 · 3 comments
Open
6 tasks

Complete Cards #8

posva opened this issue Feb 8, 2016 · 3 comments

Comments

@posva
Copy link
Owner

posva commented Feb 8, 2016

Cards are missing features:

  • Expand on title
  • Menu icon
  • Menu interaction
  • Doc how events are fired
  • Better doc on slots
  • Set background with prop
@posva posva added the ready label Feb 8, 2016
@posva posva self-assigned this Feb 8, 2016
@cassioscabral
Copy link

Could we get some background slot for the title ? I'm using a dynamic url passing down with a prop and will be good to be able to change that. Thanks

P.S.: Are you still working on that ? I'm new to Vue and I believe I could help with this issue and maybe future issues also. Would be a great way to understand more about Vue/Vue-MDL and contribute in general.

@posva
Copy link
Owner Author

posva commented Apr 21, 2016

Hi. Do you mean like the example in the doc? http://posva.net/vue-mdl/#cards
I'm always looking forward new contributions 😄
I'm not working on this specific thing, so you can go for it. The main issue here is that you have to fix the height too

@cassioscabral
Copy link

I see that you change the background-url in the CSS like that:

background: url('http://www.getmdl.io/assets/demos/welcome_card.jpg') center / cover;

I would like to change that URL passing the value via some prop or data. I was able to pass a value to media which works since the value is inserted in the img src. But couldn't figure out how to change the background alone. Something like below or just a better way to deal with custom styles in general:

<mdl-card :title="cardTitle" :supporting-text="supportingText" actions="actions" actions-text="View updates" :title-background="myBackground">
</mdl-card>

Sorry if I said something weird, today is the first day of coding with Vue and I'm still confused with a couple stuff =)

I will take a look in this issue more in depth then. Can you explain more about the checkpoints though?

Expand on Title means expand on clicking in the title ?
Menu icon and interactions, it's about the option actions ?
Are there any custom events being fired to be documented ?

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants