Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PouchDB relying on vulnerable version of node-fetch #8440

Closed
rdwoodring opened this issue Jan 24, 2022 · 9 comments
Closed

PouchDB relying on vulnerable version of node-fetch #8440

rdwoodring opened this issue Jan 24, 2022 · 9 comments

Comments

@rdwoodring
Copy link
Contributor

Issue

PouchDB relies upon a vulnerable version of node-fetch. PouchDB's package.json has the node-fetch dependency pinned at 2.6.0 as of v7.2.2. It looks like master has it pinned at 2.6.4. The vulnerability was patched in node-fetch 2.6.7

Info

  • Environment: Node & browser
  • Platform: All
  • Adapter: All
  • Server: All
  • Version: 7.2.2

Reproduce

  1. Run npm audit

Expected: No vulnerabilities
Actual: node-fetch vulnerabilities in pouchdb, pouchdb-find, pouchdb-fetch, and pouchdb-abstract-mapreduce

@joemc11
Copy link

joemc11 commented Jan 29, 2022

This is a high vulnerability, so would be great to get this fixed and published. What is the estimated time frame for this fix.
Screenshot 2022-01-29 at 20 58 07

rdwoodring added a commit to rdwoodring/pouchdb that referenced this issue Feb 2, 2022
Resolves a vulnerability present in versions of node-fetch less than 2.6.7
@rdwoodring
Copy link
Contributor Author

PR 8448 should resolve the vulnerable dependency

karlwestin pushed a commit that referenced this issue Feb 3, 2022
Resolves a vulnerability present in versions of node-fetch less than 2.6.7
@rdwoodring
Copy link
Contributor Author

@karlwestin it might not really be up to you, but do you have any idea when we might get a release with the PR that resolves this issue?

Thanks

@AuracleTech
Copy link

Any idea when we might get a release with the PR that resolves this issue?

Same. I am waiting for this update to update my apparatus.

@lgarron
Copy link

lgarron commented Feb 24, 2022

Any idea when we might get a release with the PR that resolves this issue?

Same. I am waiting for this update to update my apparatus.

Also would love to see a fix. Given that the "hard" part (fixing it in the codebase) is already done and just needs to land in a published version, it's a little hard not to see the current situation as pouchdb effectively being unmaintained. :-/

Node that npm audit fix --force would actually downgrade to pouch-db@7.0.0, which doesn't sound great.

ramblin-rose pushed a commit to ramblin-rose/pouchdb that referenced this issue Feb 24, 2022
Resolves a vulnerability present in versions of node-fetch less than 2.6.7
@AlbaHerrerias
Copy link
Contributor

node-fetch was upgraded to 2.6.7 in this PR #8448 and merged to master, therefore I'm closing this issue. We're working in a new release, it will land soon. Thank you.

@lgarron
Copy link

lgarron commented Apr 6, 2022

Any update on that release? 😃

@lgarron
Copy link

lgarron commented Jun 6, 2022

We're working in a new release, it will land soon. Thank you.

poke 🥺
Is this still planned?

@garethbowen
Copy link
Member

It's landed: https://pouchdb.com/2022/04/13/pouchdb-7.3.0.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

6 participants