Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer does not use the "go.testFlags" from settings #17

Closed
johnpan opened this issue Dec 10, 2019 · 1 comment · Fixed by #24 · May be fixed by #21
Closed

Explorer does not use the "go.testFlags" from settings #17

johnpan opened this issue Dec 10, 2019 · 1 comment · Fixed by #24 · May be fixed by #21
Labels
enhancement New feature or request

Comments

@johnpan
Copy link

johnpan commented Dec 10, 2019

Trying to avoid the known error (here ([https://github.com/golang/go/issues/28065])) "gcc": executable file not found in $PATH, I used

"go.testFlags": [
        "-vet=off"
    ]

but reading the output while testing, the tool does not add the test flags:

Running tool: /usr/local/go/bin/go test  -timeout 30s -run ^TestAreSpecificOdds$
# runtime/cgo
exec: "gcc": executable file not found in $PATH
FAIL	caching/parsers [build failed]
FAIL
Error: Tests failed.
@ppparihar ppparihar added the enhancement New feature or request label Jan 17, 2020
@bbrks
Copy link

bbrks commented Feb 19, 2020

An inferred workspace GOPATH is not being picked up when using the "go.inferGopath": true setting either. This might be closely related.

arcadien added a commit to arcadien/GoTestExplorer that referenced this issue Apr 1, 2020
@arcadien
fix: Use workspace settings.json Go config
d080f01 
fixes ppparihar#17
@arcadien arcadien mentioned this issue Apr 1, 2020
Open
@microchi microchi mentioned this issue Jul 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test flags from go config
fix: Use workspace settings.json Go config arcadien/GoTestExplorer
3 participants
@bbrks @johnpan @ppparihar