Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect use of <label for=FORM_ELEMENT> #929

Open
2 tasks done
syzexecutive opened this issue Aug 19, 2023 · 7 comments
Open
2 tasks done

Incorrect use of <label for=FORM_ELEMENT> #929

syzexecutive opened this issue Aug 19, 2023 · 7 comments

Comments

@syzexecutive
Copy link

syzexecutive commented Aug 19, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Have you updated FilePond and its plugins?

  • I have updated FilePond and its plugins

Describe the bug

Incorrect use of label for=FORM_ELEMENT

Chrome Issues shows this error. I think it's because FilePond creates a DIV with "filepond--drop-label" class and puts the label for the file input inside it. Shouldn't the label and input be together?

Reproduction

FilePond sets file input class to filepond--browser and sets random id for it and creates a DIV with "filepond--drop-label" class and puts the label for the file input inside it.

Screenshot 2023-08-19 090827

Issues tab on Chrome:

Screenshot 2023-08-19 090716

Environment

- Device: PC
- OS: Windows 11
- Browser: Chrome 116
@syzexecutive syzexecutive changed the title [Bug] [Bug] Incorrect use of label for=FORM_ELEMENT Aug 19, 2023
@syzexecutive syzexecutive changed the title [Bug] Incorrect use of label for=FORM_ELEMENT [Bug] Incorrect use of <label for=FORM_ELEMENT> Aug 19, 2023
@rikschennink
Copy link
Collaborator

It points to an input, I don't see what's wrong with that?

@syzexecutive
Copy link
Author

Yes, it points, but Chrome issues tab shows this error! How can I solve this?
I have nothing special in FilePond config and configured with basics.

@rikschennink rikschennink changed the title [Bug] Incorrect use of <label for=FORM_ELEMENT> Incorrect use of <label for=FORM_ELEMENT> Aug 23, 2023
@rikschennink
Copy link
Collaborator

@syzexecutive Perhaps it's a Chrome bug, I wouldn't worry about it.

@CelticParser
Copy link

It is not a Chrome bug. form and id need to match and they do not. This error (recently) shows differently in various browsers.

This causes uploading reliability and accessibility issues.

@rikschennink
Copy link
Collaborator

@CelticParser But they do seem to match up?

CleanShot 2023-09-29 at 11 08 56@2x

@simonmaass
Copy link

very weird... I get the same error... but not everytime...

image

@rikschennink rikschennink removed the bug label Mar 1, 2024
@rikschennink
Copy link
Collaborator

Seems like a bug in Chrome? The id is clearly there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants