Fix typings #963
Open
Fix typings #963
+32
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: not all events listed in FilePondsEvents fix: .on method of filedpond instance not inherit callback arguments types fix: manual prefixing replaced with generated
|
I'm comfortable with adding events and adding missing types, but the generated types I'd rather avoid for now. |
|
I can remove the generation for FilePondEventPrefixed, but elsewhere I have been unable to get typescript to properly inherit the callback argument type without generics. |
|
Im unfortunately not experienced enough to comment on this. I normally just describe each property/method/event separately and want to keep things in a state where I still know what’s going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: not all events listed in FilePondsEvents
fix: .on method of filedpond instance not inherit callback arguments types
fix: manual prefixing replaced with generated
Before:
After:
Fixes #962