From 2573e84868e3da6e229c4d25f65ebe17f0127323 Mon Sep 17 00:00:00 2001
From: James Knight <james.d.knight@live.com>
Date: Sat, 11 Sep 2021 20:44:36 -0400
Subject: [PATCH] Use noscript for search JS notification

The "search.html" template will generate a warning admonition about
requiring JavaScript for search and automatically hiding the element
when supported. While functional, if a client renders the page slowly,
the warning notification may be visible to the user for a moment.

Instead of relying on JavaScript to suppress this warning, use a
`noscript` tag to hide the warning for clients who do not support
JavaScript. This also has the benefit of one less JavaScript call
required by a client.

Signed-off-by: James Knight <james.d.knight@live.com>
---
 src/furo/theme/furo/search.html | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/furo/theme/furo/search.html b/src/furo/theme/furo/search.html
index 38b7eba4a..8b593283b 100644
--- a/src/furo/theme/furo/search.html
+++ b/src/furo/theme/furo/search.html
@@ -11,13 +11,14 @@
 {%- endblock htmltitle -%}
 
 {% block content %}
-<div id="fallback" class="admonition error">
+<noscript>
+<div class="admonition error">
   <p class="admonition-title">{% trans %}Error{% endtrans %}</p>
   <p>
     {% trans %}Please activate JavaScript to enable the search functionality.{% endtrans %}
   </p>
 </div>
-<script>document.getElementById('fallback').hidden = true;</script>
+</noscript>
 
 <div id="search-results"></div>
 {% endblock %}