-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom metrics README example is generating TS errors #398
Comments
Hi @laurencefass have you tried with the version |
@pragmaticivan would it be possible to declare the list of peer dependencies for this project and add that to the If you install the most recent versions there are considerable type issues with the updated interfaces and your displayed examples. See other errors as well: |
@coler-j ,let me take a look, the reason why I didn't do that in the past was that OTEL metric SDK was not respecting version stability |
Meanwhile, that's an updated working project https://github.com/pragmaticivan/nestjs-otel-prom-grafana-tempo as example |
I also think Since these dependencies were at different versions If you want @pragmaticivan I can attempt to clear this up in a PR and also add more explicit wording around dependency selection then we can close the multiple issues that exist (and might stear people away from using this library). |
The example for metrics generates a typescript error
package configuration:
Referring to this example
https://github.com/pragmaticivan/nestjs-otel#metric-service
import { Counter } from '@opentelemetry/api'; reports error
Im guessing this is another mismatch caused by updates to the api not yet updated here?
Thanks
The text was updated successfully, but these errors were encountered: