Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend check for illegal Windows filenames #1048

Open
Jeffrey-Lim opened this issue Apr 25, 2024 · 0 comments · May be fixed by #1049
Open

Extend check for illegal Windows filenames #1048

Jeffrey-Lim opened this issue Apr 25, 2024 · 0 comments · May be fixed by #1049

Comments

@Jeffrey-Lim
Copy link

Jeffrey-Lim commented Apr 25, 2024 •
edited

The check-illegal-windows-names hook does not check for every illegal filename on Windows. For example, filenames with "double" quotes are still allowed.

Update the regex so that all illegal filenames get detected. Illegal Windows filenames are defined here.
@Jeffrey-Lim Jeffrey-Lim linked a pull request Apr 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend check for illegal Windows filenames Jeffrey-Lim/pre-commit-hooks
1 participant
@Jeffrey-Lim