Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check JSON hook failing because of file used in tests #600

Closed
ibLeDy opened this issue May 15, 2021 · 0 comments · Fixed by #601
Closed

Check JSON hook failing because of file used in tests #600

ibLeDy opened this issue May 15, 2021 · 0 comments · Fixed by #601

Comments

@ibLeDy
Copy link
Contributor

ibLeDy commented May 15, 2021 •
edited

A file added in PR #558 is causing the check-json hook to fail on the latest run.

Check JSON...............................................................Failed
- hook id: check-json
- exit code: 1

testing/resources/duplicate_key_json.json: Failed to json decode (Duplicate key: hello)
ibLeDy added a commit to ibLeDy/pre-commit-hooks that referenced this issue May 15, 2021
@ibLeDy
Rename file causing check-json to fail
fed8b6d 
- `mv duplicated_key_json.{json,notjson}`
- change reference to the file in `tests/check_json_test.py`

Fixes pre-commit#600
@ibLeDy ibLeDy mentioned this issue May 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix check-json failing on ci runs ibLeDy/pre-commit-hooks
1 participant
@ibLeDy