Forbid the combination of unique and ignore case options in file_contents_sorter.py #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Oct 19, 2022
asottile
reviewed
Oct 21, 2022
Comment on lines
68
to
71
| if args.ignore_case and args.unique: | ||
| print('ERROR: usage of --unique and --ignore-case is unsupported. \ | ||
| Please update your configuration.') | ||
| return FAIL |
There was a problem hiding this comment.
don't use backslashes like this -- also this is going to render very strangely
also this behaviour needs to be tested (capsys might help) -- but then again you can probably just make this use argparse's mutually exclusive options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output when both options are specified:
Closes #794.