remove support for top-level list format #2656

asottile · 2022-12-27T16:18:10Z

this has been producing a warning since july of 2020:

$ pre-commit run flake8 --all-files
[WARNING] normalizing pre-commit configuration to a top-level map.  support for top level list will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
flake8...................................................................Passed

this now produces this error:

$ pre-commit run flake8 --all-files
An error has occurred: InvalidConfigError: 
==> File .pre-commit-config.yaml
=====> Expected a Config map but got a list
Check the log at /home/asottile/.cache/pre-commit/pre-commit.log

this can be fixed automatically by running pre-commit migrate-config:

$ pre-commit migrate-config
Configuration has been migrated.
$ pre-commit run flake8 --all-files
flake8...................................................................Passed

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit](https://github.com/pre-commit/pre-commit) | dev-dependencies | major | `^2.21.0` -> `^3.0.0` | --- ### Release Notes <details> <summary>pre-commit/pre-commit</summary> ### [`v3.2.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#322---2023-04-03) [Compare Source](pre-commit/pre-commit@v3.2.1...v3.2.2) \================== ##### Fixes - Fix support for swift >= 5.8. - [#2836](pre-commit/pre-commit#2836) PR by [@edelabar](https://github.com/edelabar). - [#2835](pre-commit/pre-commit#2835) issue by [@kgrobelny-intive](https://github.com/kgrobelny-intive). ### [`v3.2.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#321---2023-03-25) [Compare Source](pre-commit/pre-commit@v3.2.0...v3.2.1) \================== ##### Fixes - Fix `language_version` for `language: rust` without global `rustup`. - [#2823](pre-commit/pre-commit#2823) issue by [@daschuer](https://github.com/daschuer). - [#2827](pre-commit/pre-commit#2827) PR by [@asottile](https://github.com/asottile). ### [`v3.2.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#320---2023-03-17) [Compare Source](pre-commit/pre-commit@v3.1.1...v3.2.0) \================== ##### Features - Allow `pre-commit`, `pre-push`, and `pre-merge-commit` as `stages`. - [#2732](pre-commit/pre-commit#2732) issue by [@asottile](https://github.com/asottile). - [#2808](pre-commit/pre-commit#2808) PR by [@asottile](https://github.com/asottile). - Add `pre-rebase` hook support. - [#2582](pre-commit/pre-commit#2582) issue by [@BrutalSimplicity](https://github.com/BrutalSimplicity). - [#2725](pre-commit/pre-commit#2725) PR by [@mgaligniana](https://github.com/mgaligniana). ##### Fixes - Remove bulky cargo cache from `language: rust` installs. - [#2820](pre-commit/pre-commit#2820) PR by [@asottile](https://github.com/asottile). ### [`v3.1.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#311---2023-02-27) [Compare Source](pre-commit/pre-commit@v3.1.0...v3.1.1) \================== ##### Fixes - Fix `rust` with `language_version` and a non-writable host `RUSTUP_HOME`. - [pre-commit-ci/issues#173](pre-commit-ci/issues#173) by [@Swiftb0y](https://github.com/Swiftb0y). - [#2788](pre-commit/pre-commit#2788) by [@asottile](https://github.com/asottile). ### [`v3.1.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#310---2023-02-22) [Compare Source](pre-commit/pre-commit@v3.0.4...v3.1.0) \================== ##### Fixes - Fix `dotnet` for `.sln`-based hooks for dotnet>=7.0.200. - [#2763](pre-commit/pre-commit#2763) PR by [@m-rsha](https://github.com/m-rsha). - Prevent stashing when `diff` fails to execute. - [#2774](pre-commit/pre-commit#2774) PR by [@asottile](https://github.com/asottile). - [#2773](pre-commit/pre-commit#2773) issue by [@strubbly](https://github.com/strubbly). - Dependencies are no longer sorted in repository key. - [#2776](pre-commit/pre-commit#2776) PR by [@asottile](https://github.com/asottile). ##### Updating - Deprecate `language: python_venv`. Use `language: python` instead. - [#2746](pre-commit/pre-commit#2746) PR by [@asottile](https://github.com/asottile). - [#2734](pre-commit/pre-commit#2734) issue by [@asottile](https://github.com/asottile). ### [`v3.0.4`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#304---2023-02-03) [Compare Source](pre-commit/pre-commit@v3.0.3...v3.0.4) \================== ##### Fixes - Fix hook diff detection for files affected by `--textconv`. - [#2743](pre-commit/pre-commit#2743) PR by [@adamchainz](https://github.com/adamchainz). - [#2743](pre-commit/pre-commit#2743) issue by [@adamchainz](https://github.com/adamchainz). ### [`v3.0.3`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#303---2023-02-01) [Compare Source](pre-commit/pre-commit@v3.0.2...v3.0.3) \================== ##### Fixes - Revert "Prevent local `Gemfile` from interfering with hook execution.". - [#2739](pre-commit/pre-commit#2739) issue by [@Roguelazer](https://github.com/Roguelazer). - [#2740](pre-commit/pre-commit#2740) PR by [@asottile](https://github.com/asottile). ### [`v3.0.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#302---2023-01-29) [Compare Source](pre-commit/pre-commit@v3.0.1...v3.0.2) \================== ##### Fixes - Prevent local `Gemfile` from interfering with hook execution. - [#2727](pre-commit/pre-commit#2727) PR by [@asottile](https://github.com/asottile). - Fix `language: r`, `repo: local` hooks - [pre-commit-ci/issues#107](pre-commit-ci/issues#107) by [@lorenzwalthert](https://github.com/lorenzwalthert). - [#2728](pre-commit/pre-commit#2728) PR by [@asottile](https://github.com/asottile). ### [`v3.0.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#301---2023-01-26) [Compare Source](pre-commit/pre-commit@v3.0.0...v3.0.1) \================== ##### Fixes - Ensure coursier hooks are available offline after install. - [#2723](pre-commit/pre-commit#2723) PR by [@asottile](https://github.com/asottile). ### [`v3.0.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#300---2023-01-23) [Compare Source](pre-commit/pre-commit@v2.21.0...v3.0.0) \================== ##### Features - Make `language: golang` bootstrap `go` if not present. - [#2651](pre-commit/pre-commit#2651) PR by [@taoufik07](https://github.com/taoufik07). - [#2649](pre-commit/pre-commit#2649) issue by [@taoufik07](https://github.com/taoufik07). - `language: coursier` now supports `additional_dependencies` and `repo: local` - [#2702](pre-commit/pre-commit#2702) PR by [@asottile](https://github.com/asottile). - Upgrade `ruby-build` to `20221225`. - [#2718](pre-commit/pre-commit#2718) PR by [@jalessio](https://github.com/jalessio). ##### Fixes - Improve error message for invalid yaml for `pre-commit autoupdate`. - [#2686](pre-commit/pre-commit#2686) PR by [@asottile](https://github.com/asottile). - [#2685](pre-commit/pre-commit#2685) issue by [@CarstenGrohmann](https://github.com/CarstenGrohmann). - `repo: local` no longer provisions an empty `git` repo. - [#2699](pre-commit/pre-commit#2699) PR by [@asottile](https://github.com/asottile). ##### Updating - Drop support for python<3.8 - [#2655](pre-commit/pre-commit#2655) PR by [@asottile](https://github.com/asottile). - Drop support for top-level list, use `pre-commit migrate-config` to update. - [#2656](pre-commit/pre-commit#2656) PR by [@asottile](https://github.com/asottile). - Drop support for `sha` to specify revision, use `pre-commit migrate-config` to update. - [#2657](pre-commit/pre-commit#2657) PR by [@asottile](https://github.com/asottile). - Remove `pre-commit-validate-config` and `pre-commit-validate-manifest`, use `pre-commit validate-config` and `pre-commit validate-manifest` instead. - [#2658](pre-commit/pre-commit#2658) PR by [@asottile](https://github.com/asottile). - `language: golang` hooks must use `go.mod` to specify dependencies - [#2672](pre-commit/pre-commit#2672) PR by [@taoufik07](https://github.com/taoufik07). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <renovate@localhost.localdomain> Reviewed-on: https://git.goatpr0n.de/public/doxy/pulls/2 Co-authored-by: renovate <renovate@noreply.localhost> Co-committed-by: renovate <renovate@noreply.localhost>

remove support for top-level list format

0024484

asottile marked this pull request as ready for review December 27, 2022 17:09

asottile merged commit 12a979e into main Dec 27, 2022

asottile deleted the remove-list-format branch December 27, 2022 17:09

chriscerk mentioned this pull request Jun 16, 2023

[DP-2579] Upgrade ih-setup pre-commit ConsultingMD/homebrew-ih-public#56

Merged

carlos-villavicencio-adsk mentioned this pull request Aug 17, 2023

SG-30863 Fix XML coverage reporting shotgunsoftware/tk-ci-tools#42

Merged

jzhang533 mentioned this pull request Mar 6, 2024

update pre-commit config PaddlePaddle/PaddleOCR#11682

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove support for top-level list format #2656

remove support for top-level list format #2656

asottile commented Dec 27, 2022 •

edited

remove support for top-level list format #2656

remove support for top-level list format #2656

Conversation

asottile commented Dec 27, 2022 • edited

asottile commented Dec 27, 2022 •

edited