Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating url prop doesn't trigger an update #330

Open
halcaponey opened this issue Aug 9, 2019 · 0 comments · May be fixed by #332
Open

updating url prop doesn't trigger an update #330

halcaponey opened this issue Aug 9, 2019 · 0 comments · May be fixed by #332

Comments

@halcaponey
Copy link

version : 3.0.1

<Router url={props.url}>
  // ...
</Router>

In the code above if props.url is updated Router doesn't rerender.
Looking at the code it comes from the fact that state.url is used in the render method and that it's never updated with props.url

I can PR if you want.
@halcaponey halcaponey linked a pull request Aug 11, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rerender on props.url change halcaponey/preact-router
1 participant
@halcaponey