Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The road to Preact 11 #2621

Open
marvinhagemeister opened this issue Jul 12, 2020 · 85 comments
Open

The road to Preact 11 #2621

marvinhagemeister opened this issue Jul 12, 2020 · 85 comments

Comments

@marvinhagemeister
Copy link
Member

marvinhagemeister commented Jul 12, 2020

With Preact X being a great success there The 10.x release line was all about increasing ecosystem compatibility and the initiative was a complete success. Compared to Preact 8.x there are many more third party libraries that work out of the box with Preact, we saw the addition of Fragments, hooks, a revamped devtools extension, prefresh for native HMR support and much more.

In summary, we learned a ton the past year whilst maintaining Preact X and we want to push Preact even further. So the next question for us is: Where do we go from here? What should a successor look like?

This is a collection of some of our thoughts, but is in no means a concrete feature list for Preact 11. Please keep that in mind.

Size reductions

Our small (smol?) size has always been one of our strong points and the thing I'm personally the most proud of. With an ever growing feature-set we're currently very close to the 4kB mark and would like to bring that number down again. Whilst we may be able to shave of a couple bytes here and there, I think we won't have substantial changes on that front without thinking critical of each feature.

Only include what's actually used

The most common talking point is that many projects (including preact-devtools) don't use a single class component. The natural question that arises here is why we need to still pay for the cost the class API regardless. Ideally only the features that are actually used should be shipped to users.

The same is true for preact/compat which will always include side-effects even though a user may only needs to import to the Portal component for example. There have been some attempts to do that in the past, but to me it seems like some changes in core could make that easier.

The overall motto should be: Only include what's used.

Move IS_NON_DIMENSIONAL to compat

Whilst it sounded cute on paper it has turned into a growing list of properties (see #2608 ) which is something we never wanted to have in core. The reason we kept it over from the 8.x line in core, was that it allowed us to keep old codepen demos working. This was especially useful at a time where we weren't officially committing to Preact X and we were more just playing around with various approaches.

I'd even go so far as to consider it harmful as I've seen it confuse new developers first-hand when switching between writing CSS and declaring inline styles. It's a feature we cannot remove entirely because of React, but moving over to compat should be fine.

Reconciler performance

Whilst the original plan for X was to break from using the DOM for traversal and only use the vnode tree for that, we ended up in the a little bit awkward middle ground. Most operations walk the vnode tree, but there are some remaining ones that still rely on the DOM itself. This is made more difficult by the existence of Fragments.

For our next generation we should cut ties with our past and completely base it on the vnode tree instead. The newly added statistic metrics reveal some great places to look for improvements. Some of the ideas that are currently floating around:

  • Add fast path for single child elements
  • Store DOM operations in an effect queue (aka centralize paints)
  • Add fast path for mounting

The effect queue idea is in particular interesting as it would the browser to batch all paint jobs and process them at once instead of having those intertwined with running JS. Heck we could make a lot of the DOM pointer code easier by applying those changes right-to-left instead of left-to-right.

What's more is that having an effect queue would open up the possibility for custom renderers. It's a long shot and not something we'll focus on in the near term, but we would at least have the possibility to do so nonetheless.

Boosting hydration

We're already in a good position when it comes to hydration performance but we have a lot of ideas what we can do to make it even faster. Any optimizations we'll do on our reconciler will directly benefit hydration, so there is a very close connection between the two.

Besides reconciler performance, there is a need to re-evaluate how we can best boot up from SSR'ed content. Due to us not joining adjacent text nodes anymore we have a mismatch during hydration. SSR'ed HTML will always create a single text node, even if it was created from multiple ones.

// Element with two Text nodes
<div>Hello {name}</div>

An alternative to joining adjacent text nodes is to insert HTML comments as markers in-between them. Not sure which approach is ultimately easier, although my gut tells me that the latter can easily become complex.

Remove the need for forwardRef

The introduction of the forwardRef component is mostly a workaround for not keeping ref in props. If we keep it in there we can make all forwardRef components redundant:

// Current way
const Foo = forwardRef((props, ref) => <div ref={ref}>{props.children}</div>);

// Proposal
const Foo = props => <div ref={props.ref}>{props.children}</div>;

There is a downside to that though in that there may be custom runtime checks in third-party libraries that explicitly check for additional properties in the props object. We ran into some of those in the past if my memory serves me well, and I'm secretly hoping that the increasing adoption of TypeScript has improved the situation compared to a few years ago.

Mark root nodes as roots

Both the devtools and Portal component would benefit from having a way to place sub-trees into existing ones. Currently no tree knows about the others which leads to some weird edge cases with Portals. There has been fantastic work during the 10.x release line to get it stable and I feel like we can make that code easier by having a special branch for root nodes as sub-trees in our reconciler.

// This is not possible currently
<TreeA>
  <Foo />
  <root>
    <TreeB />
  </root>
</TreeA>

If we follow that thought further we could theoretically even look into switching renderes on the fly if there is any attached to the root node. A use case for that would be to switch to rendering into a canvas element somewhere in the middle of the tree.

What else can we do?

The above list is already a lot of work and will keep us busy for months but there may be stuff I've missed. Again, the points mentioned here is a collection of ideas and not a definitive feature set for Preact 11.

@38elements
Copy link
Contributor

I think that it is better that Preact 11 stops support IE11 and Edge which is not based Chromium.
Preact X will continue to support these brower.

@marvinhagemeister
Copy link
Member Author

I think that it is better that Preact 11 stops support IE11 and Edge which is not based Chromium.
Preact X will continue to support these brower.

Good idea! We should definitely drop the requirement to work out of the box with IE11. This would allow us to use Map or Set objects. IE11 users can always polyfill those. Regarding Edge: Admittedly we never had any bigger problems with it if I recall correctly. Ultimately we need to see what kind of code base we'll end up with, but I have a feeling that supporting old Edge browser doesn't require any changes on our part.

@38elements
Copy link
Contributor

Regarding Edge: Admittedly we never had any bigger problems with it if I recall correctly.

It may be unimportant thing, there is #2331.

@developit
Copy link
Member

2kb 2kb 2kb

@rauschma
Copy link

@developit mentioned plans for better supporting server-side-rendered HTML that stays at least partially functional even without JS (I found HEY inspiring here). Any details on those plans yet?

@developit
Copy link
Member

@rauschma The main things we have explored related to that are actually implemented using Preact X as it exists today, so I'd put them on an independent timeline from a Preact 11. The reason for this is that anything related to HTML ends up requiring that folks use (more) specific server-side techniques, versus the current simplified renderToString() approach.

I'll try to prioritize at least publishing some of the exploratory work and demos we have. It's less impactful than providing an off-the-shelf fullstack framework, but that's probably fine given the highly variable nature of Preact usage.

@lukejacksonn
Copy link
Sponsor

Some very interesting ideas here Marvin, thank you for airing them and thanks to the preact team generally for all their hard work on 10.x. I have committed this year to building preact apps almost exclusively and it has been a pleasure; the tools, the community, everything is like a breath of fresh air.

One thing I am wondering about the future of preact however, is, will it always try adhere to the react API? Being ~ its namesake and given all the effort that went into increasing ecosystem compatibility in X, I assume the answer to this is yes. But I am curious, if you happened to stumbled across a potentially useful new primitive or feature outside of the react API.. would it be considered?

I've been inspired recently by the likes of hyperapp and svelte with their effect and subscriptions APIs respectively. Do you see any promise in these kind of interfaces specifically, or are the team content that these kind of behaviours can be encapsulated by hooks?

@marvinhagemeister
Copy link
Member Author

Some very interesting ideas here Marvin, thank you for airing them and thanks to the preact team generally for all their hard work on 10.x. I have committed this year to building preact apps almost exclusively and it has been a pleasure; the tools, the community, everything is like a breath of fresh air.

Thank you so much for the kind words! It's comments like these that keep us motiviated! ❤️

One thing I am wondering about the future of preact however, is, will it always try adhere to the react API? Being ~ its namesake and given all the effort that went into increasing ecosystem compatibility in X, I assume the answer to this is yes. But I am curious, if you happened to stumbled across a potentially useful new primitive or feature outside of the react API.. would it be considered?

We will keep compatibility with the React API for the foreseeable future, but it's very likely that we'll put our own spin on thinks more in the future. Keeping ref in props and thereby removing the need for forwardRef is one small step in that direction.

I've been inspired recently by the likes of hyperapp and svelte with their effect and subscriptions APIs respectively. Do you see any promise in these kind of interfaces specifically, or are the team content that these kind of behaviours can be encapsulated by hooks?

Personally, I fully agree that a simple subscription primitive is very appealing and something I've played a lot in the past and shipped a few projects with. We see a lot of code in the wild where re-renders are triggered for the sole sake of triggering effects. Not saying that this bad code, but rather that hooks tend to lend itself to that usage and I'd love to welcome different ideas to Preact. So far reactivity is a leading contender to do that in my opinion.

That said we'll always try to keep that part pluggable like now as there never is a silver bullet approach and different applications require different trade-offs. One neat library that uses RxJS as a first class option to manager state for Preact components is bassdrum. There is also #1923 which adds a vue-like composition API on top of Preact as another alternative to hooks.

So yeah I see a lot of value in these concepts and we do want to make it easier for those systems to directly plug into Preact in the future. Hooks are a great approach for local state but they're by far not the only one. Our devtools extension barely uses hooks or classes for that matter for example.

@rauschma
Copy link

@developit Having something lightweight in that space would be very welcome!

@yisar
Copy link

yisar commented Jul 16, 2020

I see that the new size calculation standard is to calculate the size of Hello world project. After tree-shaking, it seems that there is no need to pay for the class API.

In addition, does the diff algorithm, which is detached from DOM, mean that it is completely detached from DOM, and vdom does not contain DOM information? If so, it would be great. I'm looking forward to it~

@marvinhagemeister
Copy link
Member Author

In addition, does the diff algorithm, which is detached from DOM, mean that it is completely detached from DOM, and vdom does not contain DOM information? If so, it would be great. I'm looking forward to it

The way vdom works is that it always needs a reference to the underlying element. There is nothing that says that this has to be a DOM node though and that can be leveraged for different renders. There is more work to it than that on the road to support custom renderers, so it may be that we lay down the groundwork in v11 and add offical support for it in v12.

@yisar
Copy link

yisar commented Jul 16, 2020

There is a way that no need underlying element, such as https://github.com/Matt-Esch/virtual-dom,
It's very primitive, but it can be used as a reference. It's a completely DOM independent approach, and is well suited for cross platforms.

@marvinhagemeister
Copy link
Member Author

Good point, I stand corrected! Creating "patch" objects and push them in an effect queue is something we thought about too. It's something where we will likely experiment more with it after Preact 11 or when we rewrite our reconciler.

@lukejacksonn
Copy link
Sponsor

lukejacksonn commented Jul 17, 2020

Thanks for your response above @marvinhagemeister 🙇

We will keep compatibility with the React API for the foreseeable future, but it's very likely that we'll put our own spin on things more in the future

This sounds sensible and I can't wait to see what our own spin ends up looking like!

I had never heard of bassdrum so will have to check it out, also #1923 looks very interesting. Keeping things pluggable seems like a good idea too. Very much looking forward to v11 now! Keep up the good work and thanks again for your insight and explanation.

@ksorv
Copy link

ksorv commented Jul 19, 2020

@marvinhagemeister I have never worked with Preact, But i happen to pass by this repo. And you can already see what I'm doing!

This is fresh, This is oxygen. I know React is mainstream, but only because it came up with the idea of components i guess.

You guys are doing awesome work. I found React very FB sided, instead of being a true OS project. They work on what FB wants(i mean that's ok) but still, thats not how OS should work.

I love React by all means, but that direction ain't fair. You guys will rock soon.

Mark my words.

Keep at it. ❤️

@marvinhagemeister
Copy link
Member Author

@sauravkhdoolia Thanks for the kind words ❤️ We share your enthusiasm and can't wait to see what's next 👍

@jeremy-coleman
Copy link
Contributor

jeremy-coleman commented Jul 23, 2020

I think preact needs a reverse complement of preact/compat, either at runtime or as a codemod. Right now, there's little incentive to use the preact namespace instead of react. As evidence of this, i think the stars to dependent projects ratio is a good indicator, maybe think of it as an adopt-ability ratio. Lower is better.
Preact 1.03 @ 26.7k/23k
Vue 0.15 @ 169k/1.15m
React 0.04 @ 153k/4.10m
Angular 0.45 @ 62.5k /1.39m
Svelte 1.66 @ 35.7k / 21.5k

If developers could use preact without fear of not being able to switch to react, i think adoption rates would be much higher, which will allow preact to not only compete for a larger chunk of the open-source mindshare , but also to allow people to actually use deviations from the react api.

@38elements
Copy link
Contributor

38elements commented Jul 25, 2020

Since most browsers support Brotli, I think it may be better to focus size compressed by Brotli, not gzip at Preact 11.
https://caniuse.com/#feat=brotli

@zgoda
Copy link

zgoda commented Jul 28, 2020

For me the top priority is performance, I don't care about React compatibility at all. Most used mode is drop in bundle with HTM as I am doing embedded apps on really small devices with just about 4 MB storage. Preact 10 is already good but if it can be better with 11 then I'm all in.

@klh
Copy link

klh commented Sep 15, 2020

I think that it is better that Preact 11 stops support IE11 and Edge which is not based Chromium.
Preact X will continue to support these brower.

Good idea! We should definitely drop the requirement to work out of the box with IE11. This would allow us to use Map or Set objects. IE11 users can always polyfill those. Regarding Edge: Admittedly we never had any bigger problems with it if I recall correctly. Ultimately we need to see what kind of code base we'll end up with, but I have a feeling that supporting old Edge browser doesn't require any changes on our part.

My two bits here:

I for one appreciate the ie11 support,
if you remove this, it will be harder to argument for Preact vs others due to lack of browser support (especially in bigCorp settings where ie11 is A LOT more common than the whole www).

if you remove it, you'll have to do some heavy lifting to assure that simple polyfilling makes preact ie11 compatible with end-2-end test suites and how-to's that work.

@klh
Copy link

klh commented Sep 15, 2020

could we move to htm and have it compiled out on build instead of vhtml by default (and save a few kb on the post build size) ?

@porfirioribeiro
Copy link

About IE11, dropping it will allow the codebase to evolve, ship less and better code for modern browsers.

Maybe it could be possible to create a IE11 compat layer? I think Vue was heading in that direction.

@marvinhagemeister
Copy link
Member Author

Now that Microsoft has dropped IE11 support officially, I'm very much in favor of doing so too 👍

@o-alexandrov
Copy link

To be precise, Microsoft also drops Edge (legacy).

@klh
Copy link

klh commented Sep 25, 2020

wish:
optional DeepEqual comparison in useState, keep the default Shallow Eval, and an optional Deep Eval.

const [ getter, setter ] = useState({DeepObject}, {deepEval:true}).

@ShadiestGoat
Copy link

Ah gotcha, I will be switching my apps then 😳

@hbroer
Copy link

hbroer commented Aug 31, 2021

Hooks and all that stuff are too "magical" to me :-D Not the way I like to build applications. I don't like that I will need a 2nd view framework related import statement because of that. Treeshaking should do its job, why excluding it from the main package? How does anybody know what is (really) used more? Does that hooks thing even work with typescript in strict mode and eslint ts recomendations? ^^

@ShadiestGoat
Copy link

@hbroer yes the whole hooks thing works perfectly with typescript ^^

@hbroer
Copy link

hbroer commented Sep 1, 2021

aside of that I can't find any good example the only one I saw is using any like smarties :-D But I don't see any benefits of hooks too. It is less descriptive and magicaly coupled. Both should be avoided. Just a few less characters to type in some usecases maybe. It also has no good way to add dependency inversion. Instead you depend on context (never liked that and I don't use it).

@ShadiestGoat
Copy link

I mean I wouldn't be arguing which one is better haha.. I used to use the classes, and it seemed very inuative, and quite simple to understand. I started up on classes, but then I looked into hooks, and yes its more complicated sometimes, but honestly, I like it more now that I'm used to it. I don't know why the only example you found was using any, but like the guide has a pretty good explanation haha...

@hbroer
Copy link

hbroer commented Oct 6, 2021

(https://preactjs.com/guide/v10/hooks) has a pretty good explanation haha...

You are right they work. I did not try that. Works better than it looks in a real world example I saw before. Still no dependency inversion, so it is a nogo for me (I use class property decorators) ;-) I can see some benefits but none of them work for my applications. The problem in my usecase is that the main component I really need is the renderer and its diffing (+ Component). I whish I would not be too lazy to make my own view renderer without the need to be compatible with the React universe :-D

Btw I only said that it is sad that the main functionality is excluded from the main package. I have no benefit of that. No one has. It only results in touching all tsx files to correct the import path. If someone doesn't use Component then it would be striped out by the tree shaking of the bundler AFAIK. IMO the hooks are a new kind to make a application. It should be it's own framework. Now we have two in one and the way I like feels like it is getting obsolete.

@ettoredn
Copy link

Is 11 ever going to happen?

@JoviDeCroock
Copy link
Member

very much working on it @ettoredn still an open-source project and we have a job outside of this as well https://github.com/preactjs/preact/tree/main

@nullpaper
Copy link

Is maintaining React compatibility a goal for Preact 11?

The release of React 18 29 Mar 2022 puts the latest version of React a fair way ahead of (or diverged from) Preact X, including several new hooks (e.g. useID, useSyncExternalStore and others) and a host of new features, including a bunch of stuff at the core of how components render.

It doesn't look like much of the React 18 new capability is considered as part of the Preact 11 roadmap (at least not from what I could tell in this ticket, or anywhere else obvious), and compatability issues are already showing up in libraries moving to support React 18 features.

@rschristian
Copy link
Member

The release of React 18 29 Mar 2022 puts the latest version of React a fair way ahead of (or diverged from) Preact X, including several new hooks (e.g. useID, useSyncExternalStore and others)

There have been a few PRs working on this, see #3402, #3498, and #3510. That last PR in particular was a fair handful of those hooks.

It doesn't look like much of the React 18 new capability is considered as part of the Preact 11 roadmap

Those last two were aimed at a Preact X release, not 11 (master branch is X, main is 11)

@cortopy
Copy link

cortopy commented May 23, 2022

@rschristian it's very promising we may get react 18 support before preact 11, but all the PRs you mention are now closed. Do you know why? there doesn't seem to be any alternative PR that supersede

@HummingMind
Copy link

Is there any information on Preact 11? Features planned, release date, etc.?
Thank you.

@ettoredn
Copy link

It has come to my attention that there exists a thing called React.

@kurtextrem
Copy link

It has come to my attention that there exists a thing called React.

Is this a troll comment?

Is there any information on Preact 11? Features planned, release date, etc.? Thank you.

Not sure if related to Preact 11, but take a look at Jason's Twitter: https://twitter.com/_developit/status/1549001036802625536?t=dKVS_S-_8fDUS-x8qO7Ymw

@JoviDeCroock
Copy link
Member

JoviDeCroock commented Jul 20, 2022

Let me write a bit of an update on this topic as we have been hard at work, currently we have a branch in parallel to master named main which contains the code for v11.

As you might have noticed we are still very actively releasing on Preact X because we have been finding a lot of things we can improve. Among these releases have been several fixes to event-handling, repeating renders, consistency of hooks, .... I personally think there is a few more low hanging fruits we can tackle in X. These changes are then copied over to 11 because we want to make stuff great and usable for all of you.

Current changes in 11:

These are the externally facing changes that most of you will notice from the start, however internally we have changed a lot. We have moved to a backing VNode structure. This means that rather than seeing a lot of GC runs during diffing/... we will retain our objects longer (for their entire lifetime), currently in Preact we use the elements from createElement and assign our runtime onto those. This is the first improvement here, which reduces memory usage by a lot and should really bootstrap us to make all the changes we want to do in the future.

We have introduced a new way of diffing arrays of children based on a skew indicator, this looks like a superficial algo fix but it solves some consistency problems that are currently present in X in relation to focus loss or remounting children that shouldn't be.

We have reduced the possible code-paths that are traversed during hydration/initial mount to guarantee that when your server-side HTML hydrates or when your client-side app renders for the first time that we follow the most optimal path, noone likes waiting for their application 😄

I hope this short summary is at least sufficient for all of you, we have a first experimental tag released on npm which we have used to update preact-devtools and prefresh already for when we feel ready to release to the general public.

The tweet from Jason there can also be used with Preact X

@gu-stav
Copy link

gu-stav commented Jul 20, 2022

@JoviDeCroock Thank you so much for the update. I guess I can speak for many people, when I say: thank you for your hard work and the amount of thinking + experimentation you all put into moving the framework/ library (don't pin me on that :D) forward.

@ConradSollitt
Copy link

Hi @JoviDeCroock

I've read briefly about this update recently and your post is the most detailed I've read so far so thanks for this info.

I have a few questions (hopefully quick):

  • Regardless of size differences will there be any known performance differences between using a CDN version of Preact vs using Vite, Webpack, or other build processes?
    • I ask because I typically use Preact from a CDN rather than a build process.
  • Is there a CDN link or recommended migration method for helping testing the new version with existing apps?
  • Are there any remaining tasks for the new version that you need help with?

Great job to you and everyone who worked on the new version. I'm excited to try it out as I'm aware it can have significant performance improvements for some apps!

@JoviDeCroock
Copy link
Member

Typically through CDN's (or at least how they currently work) you won't benefit from tree-shaking so class-components won't be shaken out but that improvement could be offset by just the download being very fast from your CDN 😄 Currently we have 1 experimental publish (https://cdn.skypack.dev/-/preact@v11.0.0-experimental.1-ZmOf9FnGoQoU8MTBuc9y/dist=es2019,mode=imports/optimized/preact.js) but that is a bit outdated compared to the current main so feel free to wait for our alpha's to start appearing.

I will try and make a set of open-tasks with the team but can't promise anything atm 😅 personally it's a very busy time

@HummingMind
Copy link

Great information.

Thank you!

@lolyinseo
Copy link

lolyinseo commented Aug 5, 2022

I want to write a few thoughts about Suspense\Lazy. I'm not a pro, so I apologize right away, these are just the ideas of a preact user ...

  1. If Suspense work with Promise why does it only handle only one state == fulfilled ? isn't it logical use all state?
html`
<${Suspense} rejected=${Reject} pending=${Pending} />
  <${Foo}>
    <${SomePromiseComponent /}>
  </${Foo}>
</${Suspense}>
`
  1. What happens if Suspense will contains several Promise?
html`
<${Suspense} fallback={<div>loading...</div>} />
  <${Foo}>
	<${SomePromiseComponent1} />
	<${SomePromiseComponent2} />
	<${SomePromiseComponent3} />
	<${SomePromiseComponent4} />
  </${Foo}>
</${Suspense}>
`

  1. Why can't I use Component as fallback like that?
class Fallback extends Component {
	render() {
		return html`<div>loading...</div>`;
	}
}

html`
<${Suspense} fallback=${Fallback} />
  <${Foo}>
	<${SomePromiseComponent} />
  </${Foo}>
</${Suspense}>
`
  1. If Lazy It's just Promise, It could just get rid of that object and let render return Promise?
class Pending extends Component {
	render() {
		return html`<div>loading...</div>`;
	}
}

class SomePromiseComponent extends Component {
	render() {
		return new Promise(resolve => resolve(html`<div>I.am Ready to GO...</div>`)) ;
	}
}

html`
<${Suspense} pending=${Pending} />
  <${Foo}>
	<${SomePromiseComponent} />
  </${Foo}>
</${Suspense}>
  1. or even easier without Suspense and Lazy! if let's render return Promise we don't need these objects
class Reject extends Component {
	render() {
		return html`<div>I am Error</div>`;
	}
}

class Pending extends Component {
	render() {
		return html`<div>loading...</div>`;
	}
}

class SomePromiseComponent extends Component {
	render() {
		return new Promise(resolve => resolve(html`<div>I.am Ready to GO...</div>`)) ;
	}
}

html`
  <${Foo}>
	<${SomePromiseComponent} pending=${Pending} rejected=${Reject}/>
  </${Foo}>

@intrnl
Copy link
Contributor

intrnl commented Aug 5, 2022

as Suspense is in preact/compat, it follows React's behavior as to how it works, and that should pretty much answer the question as to why things behaves as it is now, but here's some additional details:

  1. Suspense can keep track of multiple promises that are being thrown, this is handled just fine and acts like Promise.all
  2. Passing an element instead of component for the fallback prop allows for passing props easily to the fallback component, and also allows for non-components as well. Sure, there could be a check for either a component or an element but IMO it's best to just stick to one usage
  3. This makes both pending and rejected a reserved property, which isn't really a good idea.

@lolyinseo
Copy link

lolyinseo commented Aug 5, 2022

Suspense is in preact/compat, it follows React's behavior as

Suspense will be in the core, and as I show next, this entity is not needed at all if Component are allowed to return Promise.. (not sure about Component , maybe it's better class SomePromiseComponent extends Suspense)

Suspense can keep track of multiple promises that are being thrown, this is handled just fine and acts like Promise.all

Ok. If I want a behavior of Promise.any?, another constraint that removes the use render (return new Promise())

Passing an element instead of component for the fallback prop allows for passing props easily to the fallback component, and also allows for non-components as well. Sure, there could be a check for either a component or an element but IMO it's best to just stick to one usage

Nope. If I use logic on classes I expect it to work everywhere. I will even say more, it can be used now, but it looks weird...
<${Suspense} fallback=${html<${Fallback} />}>

This makes both pending and rejected a reserved property, which isn't really a good idea.

It does not matter. Names can be anything...

@intrnl
Copy link
Contributor

intrnl commented Nov 21, 2022

most likely it'd just be implemented as part of compat, we could probably do it now actually

the use hook seems like it's just an alias for throwing, so you can get most of the way there by doing

function use (promise) {
  if ('then' in promise) {
    throw promise;
  }

  return promise;
}

there's some stuff not covered like caching the result of a promise but that can be easily added

there's one part of the use proposal that I'm not sure if Preact should implement properly though, and it's the part involving monkeypatching fetch API

@karlhorky
Copy link

Any plans on a React Server Components implementation in Preact for v11? Would be great to get async function components that run server-only, DX is 🔥 https://twitter.com/karlhorky/status/1633104690907947008

I saw this but it seems like there's not much going on there:

@quantizor
Copy link

Any plans on a React Server Components implementation in Preact for v11? Would be great to get async function components that run server-only, DX is 🔥 https://twitter.com/karlhorky/status/1633104690907947008

I saw this but it seems like there's not much going on there:

If this does move forward, please don't kill use of the useContext API like React did.

@ShinobiWPS
Copy link

Any plans on a React Server Components implementation in Preact for v11? Would be great to get async function components that run server-only, DX is 🔥 https://twitter.com/karlhorky/status/1633104690907947008

I saw this but it seems like there's not much going on there:

In another section i've read the reply of a Preact main contributor saying that with preact-iso + Suspense you can achieve 90% of benefits of async server components, but honeslty i didn't get how

@PodaruDragos
Copy link
Contributor

PodaruDragos commented Apr 22, 2024

I din't see any mentions of performance on 11. Are there any performance improvements ? I saw that there are some v11- prefixed branches and judging by the names I assume some performance improvements were tried and/or considered.

PS: I would really like to see the new goodies improving perf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests