Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect sourcemap line mapping in tests #2929

Merged
merged 1 commit into from Jan 14, 2021

Conversation

marvinhagemeister
Copy link
Member

Forgot to tell babel to always generate sourcemaps, otherwise the line mappings are wrong in stack traces or breakpoints won't be hit.

@github-actions
Copy link

github-actions bot commented Jan 14, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +1% (-1.00ms - +1.26ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.21ms - +1.33ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-13.50ms - +19.37ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +4% (-0.62ms - +1.05ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +3% (-1.73ms - +4.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -6% - +8% (-1.97ms - +2.68ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #714
  • Commit: 1689191

duration

VersionAvg timevs preact-mastervs preact-local
preact-master146.97ms - 148.46ms-unsure 🔍
-1% - +1%
-1.26ms - +1.00ms
preact-local146.99ms - 148.69msunsure 🔍
-1% - +1%
-1.00ms - +1.26ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.61ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master54.96ms - 55.50ms-unsure 🔍
-1% - +0%
-0.64ms - +0.12ms
preact-local55.22ms - 55.76msunsure 🔍
-0% - +1%
-0.12ms - +0.64ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master86.33ms - 87.14ms-unsure 🔍
-1% - +1%
-0.61ms - +0.50ms
preact-local86.41ms - 87.16msunsure 🔍
-1% - +1%
-0.50ms - +0.61ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master99.20ms - 101.31ms-unsure 🔍
-2% - +1%
-1.82ms - +0.57ms
preact-local100.31ms - 101.44msunsure 🔍
-1% - +2%
-0.57ms - +1.82ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master53.59ms - 55.19ms-unsure 🔍
-1% - +2%
-0.74ms - +1.04ms
preact-local53.85ms - 54.63msunsure 🔍
-2% - +1%
-1.04ms - +0.74ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master99.29ms - 104.38ms-unsure 🔍
-4% - +3%
-4.40ms - +2.74ms
preact-local100.16ms - 105.17msunsure 🔍
-3% - +4%
-2.74ms - +4.40ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master54.03ms - 54.79ms-unsure 🔍
-1% - +1%
-0.30ms - +0.62ms
preact-local53.98ms - 54.51msunsure 🔍
-1% - +1%
-0.62ms - +0.30ms
-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 90
  • Built by: CI #714
  • Commit: 1689191

duration

VersionAvg timevs preact-mastervs preact-local
preact-master28.44ms - 30.14ms-unsure 🔍
-5% - +4%
-1.33ms - +1.21ms
preact-local28.41ms - 30.29msunsure 🔍
-4% - +5%
-1.21ms - +1.33ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.52ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
07_create10k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #714
  • Commit: 1689191

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1743.70ms - 1769.18ms-unsure 🔍
-1% - +1%
-19.37ms - +13.50ms
preact-local1748.99ms - 1769.75msunsure 🔍
-1% - +1%
-13.50ms - +19.37ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #714
  • Commit: 1689191

duration

VersionAvg timevs preact-mastervs preact-local
preact-master23.34ms - 24.68ms-unsure 🔍
-4% - +3%
-1.05ms - +0.62ms
preact-local23.72ms - 24.73msunsure 🔍
-3% - +4%
-0.62ms - +1.05ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #714
  • Commit: 1689191

duration

VersionAvg timevs preact-mastervs preact-local
preact-master150.56ms - 155.28ms-unsure 🔍
-3% - +1%
-4.01ms - +1.73ms
preact-local152.43ms - 155.69msunsure 🔍
-1% - +3%
-1.73ms - +4.01ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.22ms-unsure 🔍
-0% - +0%
-0.01ms - +0.02ms
preact-local6.19ms - 6.21msunsure 🔍
-0% - +0%
-0.02ms - +0.01ms
-
many_updates
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #714
  • Commit: 1689191

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.16ms - 36.07ms-unsure 🔍
-8% - +6%
-2.68ms - +1.97ms
preact-local33.15ms - 36.78msunsure 🔍
-6% - +8%
-1.97ms - +2.68ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #714
  • Commit: 1689191

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.98ms - 3.01ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-local2.99ms - 3.02msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.431% when pulling 32a4f9a on sourcemap-offset into efee8cf on master.

@github-actions
Copy link

Size Change: 0 B

Total Size: 42.4 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.05 kB 0 B
dist/preact.min.js 4.08 kB 0 B
dist/preact.module.js 4.08 kB 0 B
dist/preact.umd.js 4.12 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 5c6a381 into master Jan 14, 2021
@marvinhagemeister marvinhagemeister deleted the sourcemap-offset branch January 14, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants