Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat/jsx-dev-runtime missing in package #2931

Merged
merged 1 commit into from Jan 15, 2021

Conversation

marvinhagemeister
Copy link
Member

Fixes #2930

@github-actions
Copy link

github-actions bot commented Jan 15, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +1% (-0.97ms - +0.90ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -3% - +5% (-1.17ms - +1.73ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-7.72ms - +16.96ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +3% (-0.44ms - +0.78ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-1.99ms - +2.27ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -7% - +6% (-2.46ms - +2.21ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +1% (-0.03ms - +0.02ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #716
  • Commit: 670726d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master170.81ms - 172.20ms-unsure 🔍
-1% - +1%
-0.90ms - +0.97ms
preact-local170.85ms - 172.09msunsure 🔍
-1% - +1%
-0.97ms - +0.90ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.61ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master65.39ms - 66.20ms-unsure 🔍
-1% - +1%
-0.76ms - +0.34ms
preact-local65.63ms - 66.38msunsure 🔍
-1% - +1%
-0.34ms - +0.76ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master102.21ms - 103.56ms-unsure 🔍
-1% - +1%
-0.67ms - +1.11ms
preact-local102.09ms - 103.24msunsure 🔍
-1% - +1%
-1.11ms - +0.67ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master116.93ms - 118.17ms-unsure 🔍
-1% - +1%
-1.10ms - +0.63ms
preact-local117.18ms - 118.39msunsure 🔍
-1% - +1%
-0.63ms - +1.10ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master62.93ms - 63.58ms-unsure 🔍
-1% - +1%
-0.39ms - +0.49ms
preact-local62.90ms - 63.49msunsure 🔍
-1% - +1%
-0.49ms - +0.39ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master120.24ms - 125.47ms-unsure 🔍
-4% - +2%
-4.97ms - +2.61ms
preact-local121.30ms - 126.78msunsure 🔍
-2% - +4%
-2.61ms - +4.97ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master62.27ms - 63.13ms-unsure 🔍
-0% - +1%
-0.23ms - +0.70ms
preact-local62.28ms - 62.64msunsure 🔍
-1% - +0%
-0.70ms - +0.23ms
-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 110
  • Built by: CI #716
  • Commit: 670726d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master36.95ms - 38.85ms-unsure 🔍
-5% - +3%
-1.73ms - +1.17ms
preact-local37.09ms - 39.27msunsure 🔍
-3% - +5%
-1.17ms - +1.73ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
07_create10k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #716
  • Commit: 670726d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1662.10ms - 1680.63ms-unsure 🔍
-1% - +0%
-16.96ms - +7.72ms
preact-local1667.84ms - 1684.13msunsure 🔍
-0% - +1%
-7.72ms - +16.96ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #716
  • Commit: 670726d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master27.85ms - 28.69ms-unsure 🔍
-3% - +2%
-0.78ms - +0.44ms
preact-local28.00ms - 28.88msunsure 🔍
-2% - +3%
-0.44ms - +0.78ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #716
  • Commit: 670726d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master162.36ms - 165.89ms-unsure 🔍
-1% - +1%
-2.27ms - +1.99ms
preact-local163.07ms - 165.46msunsure 🔍
-1% - +1%
-1.99ms - +2.27ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.22ms-unsure 🔍
-0% - +0%
-0.00ms - +0.02ms
preact-local6.19ms - 6.20msunsure 🔍
-0% - +0%
-0.02ms - +0.00ms
-
many_updates
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #716
  • Commit: 670726d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.13ms - 36.61ms-unsure 🔍
-6% - +7%
-2.21ms - +2.46ms
preact-local33.19ms - 36.30msunsure 🔍
-7% - +6%
-2.46ms - +2.21ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #716
  • Commit: 670726d

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.06ms - 3.10ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms
preact-local3.05ms - 3.09msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.431% when pulling c30cc61 on compat-runtime into 5c6a381 on master.

@marvinhagemeister marvinhagemeister merged commit 70713e4 into master Jan 15, 2021
@marvinhagemeister marvinhagemeister deleted the compat-runtime branch January 15, 2021 13:51
@sventschui
Copy link
Member

Thanks a lot @marvinhagemeister !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsx-dev-runtime file is missing in preact/compat after upgrading to 10.5.10
4 participants