Tests: Fix vscode breakpoints not being hit #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Results02_replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
03_update10th1k_x16duration
usedJSHeapSize
07_create10kduration
usedJSHeapSize
filter_listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many_updatesduration
usedJSHeapSize
text_updateduration
usedJSHeapSize
|
marvinhagemeister
force-pushed
the
vscode-breakpoints
branch
from
657c77c
to
e5a98d4
Compare
|
Size Change: 0 B Total Size: 42.4 kB ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that inline source mapping paths are always resolved relative to the source file which had the
//# sourceMappingURL=comment. This doesn't play well with breakpoints set from vscode as they expect it to be a straight forward mapping between paths. This is usually the absolute path to the file and vscode has apathMappingsetting to swap out prefixes.The way webpack solves it, is by always resolving paths to the current working directory and appending
webpack:///./in front of every url. Didn't want to use that, so instead we'll always use the absolute mapping instead. This leads to the launch configuration being shortened to:{ "type": "chrome", "request": "attach", "name": "Attach Karma", "address": "localhost", "port": 9333 }To be able to do that I had switch away from inline source maps in
karma-esbuild. They are now always a separate file. An interesting advantage of this approach is that live-editing in Chrome of JS files is much smoother, and IE11 doesn't lag as much when inspecting tests 🎉