Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail build on missing compat entries in files entry #2934

Merged
merged 2 commits into from Jan 17, 2021
Merged

Fail build on missing compat entries in files entry #2934

merged 2 commits into from Jan 17, 2021

Conversation

marvinhagemeister
Copy link
Member

Add a post build script to verify that all entry files in compat are present in the "files" entry in package.json. Discovered that compat/test-utils.js was never shipped in our npm package with that. In the long run the hope is that everyone plays nice and respects the defined package entries in "exports". Until then this should allow us to catch missing files and prevent issues like #2930 from happening.

@github-actions
Copy link

github-actions bot commented Jan 16, 2021 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-4.43ms - +1.07ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +2% (-1.54ms - +0.53ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-12.01ms - +14.67ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +3% (-0.70ms - +0.86ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-1.38ms - +2.07ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -8% - +7% (-2.61ms - +2.32ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -4% - +3% (-0.12ms - +0.11ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 70
  • Built by: CI #724

  • Commit: e045eb3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master198.83ms - 202.62ms-unsure 🔍
-1% - +2%
-1.07ms - +4.43ms
preact-local197.05ms - 201.04msunsure 🔍
-2% - +1%
-4.43ms - +1.07ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local3.60ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master73.27ms - 75.32ms-unsure 🔍
-3% - +1%
-2.65ms - +0.53ms
preact-local74.15ms - 76.57msunsure 🔍
-1% - +4%
-0.53ms - +2.65ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master113.38ms - 116.01ms-unsure 🔍
-2% - +1%
-2.18ms - +1.70ms
preact-local113.51ms - 116.36msunsure 🔍
-1% - +2%
-1.70ms - +2.18ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master129.84ms - 133.17ms-unsure 🔍
-2% - +1%
-3.02ms - +1.63ms
preact-local130.57ms - 133.83msunsure 🔍
-1% - +2%
-1.63ms - +3.02ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master75.00ms - 77.53ms-unsure 🔍
-2% - +2%
-1.81ms - +1.69ms
preact-local75.11ms - 77.53msunsure 🔍
-2% - +2%
-1.69ms - +1.81ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master143.92ms - 148.67ms-unsure 🔍
-2% - +2%
-2.92ms - +3.03ms
preact-local144.45ms - 148.02msunsure 🔍
-2% - +2%
-3.03ms - +2.92ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master76.95ms - 79.34ms-unsure 🔍
-1% - +3%
-0.72ms - +2.48ms
preact-local76.20ms - 78.33msunsure 🔍
-3% - +1%
-2.48ms - +0.72ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 110
  • Built by: CI #724

  • Commit: e045eb3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master32.32ms - 33.89ms-unsure 🔍
-2% - +5%
-0.53ms - +1.54ms
preact-local31.92ms - 33.28msunsure 🔍
-5% - +2%
-1.54ms - +0.53ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #724

  • Commit: e045eb3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1570.21ms - 1587.93ms-unsure 🔍
-1% - +1%
-14.67ms - +12.01ms
preact-local1570.42ms - 1590.37msunsure 🔍
-1% - +1%
-12.01ms - +14.67ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #724

  • Commit: e045eb3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master28.17ms - 29.03ms-unsure 🔍
-3% - +2%
-0.86ms - +0.70ms
preact-local28.02ms - 29.33msunsure 🔍
-2% - +3%
-0.70ms - +0.86ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #724

  • Commit: e045eb3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master139.37ms - 141.99ms-unsure 🔍
-1% - +1%
-2.07ms - +1.38ms
preact-local139.90ms - 142.15msunsure 🔍
-1% - +1%
-1.38ms - +2.07ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.23ms-unsure 🔍
-0% - +1%
-0.01ms - +0.03ms
preact-local6.19ms - 6.21msunsure 🔍
-1% - +0%
-0.03ms - +0.01ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #724

  • Commit: e045eb3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master32.33ms - 35.82ms-unsure 🔍
-7% - +8%
-2.32ms - +2.61ms
preact-local32.18ms - 35.66msunsure 🔍
-8% - +7%
-2.61ms - +2.32ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #724

  • Commit: e045eb3

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.07ms - 3.27ms-unsure 🔍
-3% - +4%
-0.11ms - +0.12ms
preact-local3.12ms - 3.21msunsure 🔍
-4% - +3%
-0.12ms - +0.11ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.431% when pulling dbe95b6 on compat-entry into 4a54b86 on master.

@github-actions
Copy link

Size Change: 0 B

Total Size: 42.4 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.05 kB 0 B
dist/preact.min.js 4.08 kB 0 B
dist/preact.module.js 4.08 kB 0 B
dist/preact.umd.js 4.12 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

andrewiggins
andrewiggins approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@marvinhagemeister marvinhagemeister merged commit 19549d8 into master Jan 17, 2021
@marvinhagemeister marvinhagemeister deleted the compat-entry branch January 17, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhagemeister @coveralls @andrewiggins