Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Fix stack traces not sourcemapped #2935

Merged
merged 2 commits into from Jan 17, 2021
Merged

Tests: Fix stack traces not sourcemapped #2935

merged 2 commits into from Jan 17, 2021

Conversation

marvinhagemeister
Copy link
Member

Turns out that for source-mapped stack traces to work we need to set an undocumented property on karma's file object. The recent update to karma-esbuild fixes that.

@github-actions
Copy link

github-actions bot commented Jan 17, 2021 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +2% (-4.66ms - +3.14ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -6% - +2% (-1.86ms - +0.48ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -3% - +3% (-48.55ms - +50.03ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -3% - +1% (-0.97ms - +0.32ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +2% (-0.73ms - +3.41ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -10% - +5% (-3.57ms - +1.72ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -2% - +5% (-0.07ms - +0.18ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - -0% (-0.04ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #728

  • Commit: db004a2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master175.99ms - 181.83ms-unsure 🔍
-2% - +3%
-3.14ms - +4.66ms
preact-local175.57ms - 180.73msunsure 🔍
-3% - +2%
-4.66ms - +3.14ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.60ms - 3.61ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.60ms - 3.61msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master67.33ms - 68.91ms-unsure 🔍
-2% - +3%
-1.41ms - +1.89ms
preact-local66.43ms - 69.32msunsure 🔍
-3% - +2%
-1.89ms - +1.41ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master103.38ms - 105.53ms-unsure 🔍
-2% - +1%
-2.10ms - +1.07ms
preact-local103.80ms - 106.14msunsure 🔍
-1% - +2%
-1.07ms - +2.10ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master115.98ms - 119.89ms-unsure 🔍
-4% - +1%
-4.81ms - +1.38ms
preact-local117.24ms - 122.05msunsure 🔍
-1% - +4%
-1.38ms - +4.81ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master63.88ms - 67.10ms-unsure 🔍
-3% - +3%
-2.15ms - +2.09ms
preact-local64.14ms - 66.90msunsure 🔍
-3% - +3%
-2.09ms - +2.15ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master123.50ms - 129.93ms-unsure 🔍
-5% - +2%
-6.50ms - +2.68ms
preact-local125.35ms - 131.90msunsure 🔍
-2% - +5%
-2.68ms - +6.50ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master64.37ms - 66.85ms-unsure 🔍
-3% - +2%
-1.98ms - +1.52ms
preact-local64.61ms - 67.07msunsure 🔍
-2% - +3%
-1.52ms - +1.98ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 130
  • Built by: CI #728

  • Commit: db004a2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master28.76ms - 30.40ms-unsure 🔍
-2% - +6%
-0.48ms - +1.86ms
preact-local28.05ms - 29.72msunsure 🔍
-6% - +2%
-1.86ms - +0.48ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.52ms - 3.53ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.52ms - 3.53msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #728

  • Commit: db004a2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1727.33ms - 1794.29ms-unsure 🔍
-3% - +3%
-50.03ms - +48.55ms
preact-local1725.38ms - 1797.73msunsure 🔍
-3% - +3%
-48.55ms - +50.03ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.99ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.99ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #728

  • Commit: db004a2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master27.33ms - 28.25ms-unsure 🔍
-1% - +4%
-0.32ms - +0.97ms
preact-local27.01ms - 27.91msunsure 🔍
-3% - +1%
-0.97ms - +0.32ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #728

  • Commit: db004a2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master142.05ms - 145.13ms-unsure 🔍
-2% - +0%
-3.41ms - +0.73ms
preact-local143.55ms - 146.32msunsure 🔍
-1% - +2%
-0.73ms - +3.41ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.23ms-unsure 🔍
-0% - +1%
-0.00ms - +0.04ms
preact-local6.19ms - 6.20msunsure 🔍
-1% - -0%
-0.04ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #728

  • Commit: db004a2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master33.16ms - 36.99ms-unsure 🔍
-5% - +11%
-1.72ms - +3.57ms
preact-local32.33ms - 35.96msunsure 🔍
-10% - +5%
-3.57ms - +1.72ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.85ms - 4.85ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.85ms - 4.85msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 170
  • Built by: CI #728

  • Commit: db004a2

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.50ms - 3.69ms-unsure 🔍
-5% - +2%
-0.18ms - +0.07ms
preact-local3.57ms - 3.73msunsure 🔍
-2% - +5%
-0.07ms - +0.18ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

coveralls commented Jan 17, 2021 •
edited

Coverage Status

Coverage remained the same at 99.431% when pulling 4342c4e on sourcemap-error2 into 19549d8 on master.

@github-actions
Copy link

github-actions bot commented Jan 17, 2021 •
edited

Size Change: 0 B

Total Size: 42.4 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 4.05 kB 0 B
dist/preact.min.js 4.08 kB 0 B
dist/preact.module.js 4.08 kB 0 B
dist/preact.umd.js 4.12 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

andrewiggins
andrewiggins approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@andrewiggins andrewiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🙌

@marvinhagemeister marvinhagemeister merged commit 7bc661b into master Jan 17, 2021
@marvinhagemeister marvinhagemeister deleted the sourcemap-error2 branch January 17, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewiggins andrewiggins andrewiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhagemeister @coveralls @andrewiggins