Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass all props to createElement instead of just is [-5b] #2943

Merged
merged 2 commits into from Jan 20, 2021
Merged

Pass all props to createElement instead of just is [-5b] #2943

merged 2 commits into from Jan 20, 2021

Conversation

developit
Copy link
Member

The second argument to createElement accepts an object, but only looks at the is property. We can just always pass props (or we could remove this feature? not sure if it's actually still being used).

@github-actions
Copy link

github-actions bot commented Jan 20, 2021 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +2% (-2.93ms - +2.58ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -7% - +1% (-2.03ms - +0.24ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-7.61ms - +11.13ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -4% - +4% (-0.99ms - +1.09ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +2% (-4.01ms - +2.83ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -9% - +5% (-3.65ms - +2.03ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +0% (-0.03ms - +0.00ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #750

  • Commit: fe15192

duration

VersionAvg timevs preact-mastervs preact-local
preact-master163.84ms - 167.72ms-unsure 🔍
-2% - +2%
-2.58ms - +2.93ms
preact-local163.64ms - 167.56msunsure 🔍
-2% - +2%
-2.93ms - +2.58ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.59ms - 3.61ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-local3.59ms - 3.60msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master62.52ms - 64.08ms-unsure 🔍
-2% - +1%
-1.30ms - +0.76ms
preact-local62.90ms - 64.25msunsure 🔍
-1% - +2%
-0.76ms - +1.30ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master98.54ms - 101.00ms-unsure 🔍
-1% - +2%
-1.05ms - +2.16ms
preact-local98.18ms - 100.25msunsure 🔍
-2% - +1%
-2.16ms - +1.05ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master110.91ms - 114.08ms-unsure 🔍
-3% - +1%
-3.09ms - +1.45ms
preact-local111.69ms - 114.95msunsure 🔍
-1% - +3%
-1.45ms - +3.09ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master61.84ms - 64.11ms-unsure 🔍
-2% - +4%
-0.93ms - +2.19ms
preact-local61.27ms - 63.42msunsure 🔍
-3% - +1%
-2.19ms - +0.93ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master121.92ms - 124.81ms-unsure 🔍
-2% - +2%
-2.36ms - +2.73ms
preact-local121.09ms - 125.27msunsure 🔍
-2% - +2%
-2.73ms - +2.36ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master60.42ms - 61.97ms-unsure 🔍
-2% - +2%
-1.41ms - +0.94ms
preact-local60.54ms - 62.32msunsure 🔍
-2% - +2%
-0.94ms - +1.41ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 130
  • Built by: CI #750

  • Commit: fe15192

duration

VersionAvg timevs preact-mastervs preact-local
preact-master28.75ms - 30.43ms-unsure 🔍
-1% - +7%
-0.24ms - +2.03ms
preact-local27.94ms - 29.45msunsure 🔍
-7% - +1%
-2.03ms - +0.24ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.51ms - 3.52ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #750

  • Commit: fe15192

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1350.23ms - 1362.87ms-unsure 🔍
-1% - +1%
-11.13ms - +7.61ms
preact-local1351.38ms - 1365.23msunsure 🔍
-1% - +1%
-7.61ms - +11.13ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.98ms - 25.98ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.98ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #750

  • Commit: fe15192

duration

VersionAvg timevs preact-mastervs preact-local
preact-master24.82ms - 26.29ms-unsure 🔍
-4% - +4%
-1.09ms - +0.99ms
preact-local24.87ms - 26.35msunsure 🔍
-4% - +4%
-0.99ms - +1.09ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #750

  • Commit: fe15192

duration

VersionAvg timevs preact-mastervs preact-local
preact-master143.82ms - 148.71ms-unsure 🔍
-2% - +3%
-2.83ms - +4.01ms
preact-local143.27ms - 148.06msunsure 🔍
-3% - +2%
-4.01ms - +2.83ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.19ms - 6.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 80
  • Built by: CI #750

  • Commit: fe15192

duration

VersionAvg timevs preact-mastervs preact-local
preact-master36.63ms - 40.65ms-unsure 🔍
-5% - +10%
-2.03ms - +3.65ms
preact-local35.82ms - 39.83msunsure 🔍
-9% - +5%
-3.65ms - +2.03ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.84ms - 4.84ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.84ms - 4.84msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.141
  • Sample size: 50
  • Built by: CI #750

  • Commit: fe15192

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.85ms - 2.88ms-unsure 🔍
-0% - +1%
-0.00ms - +0.03ms
preact-local2.84ms - 2.87msunsure 🔍
-1% - +0%
-0.03ms - +0.00ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

coveralls commented Jan 20, 2021 •
edited

Coverage Status

Coverage remained the same at 99.438% when pulling d69f8d1 on golf-props-is into d6438b3 on master.

@github-actions
Copy link

github-actions bot commented Jan 20, 2021 •
edited

Size Change: -20 B (0%)

Total Size: 42 kB

Filename Size Change
dist/preact.js 3.95 kB -5 B (0%)
dist/preact.min.js 3.98 kB -5 B (0%)
dist/preact.module.js 3.98 kB -5 B (0%)
dist/preact.umd.js 4.02 kB -5 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@developit
Copy link
Member Author

yay, looks like it's performance-neutral.

@developit developit marked this pull request as ready for review January 20, 2021 04:23
@developit developit changed the title Pass all props to createElement instead of just is Pass all props to createElement instead of just is [-5b] Jan 20, 2021
@marvinhagemeister marvinhagemeister merged commit 7dcc323 into master Jan 20, 2021
@marvinhagemeister marvinhagemeister deleted the golf-props-is branch January 20, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@developit @coveralls @marvinhagemeister