Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate benchmarks into their own workflow #2944

Merged
merged 4 commits into from Jan 20, 2021

Conversation

andrewiggins
Copy link
Member

This change enables us to only run benchmarks on PRs that change files relevant to the benchmarks.

For example, if I did this correctly, this PR should not have any benchmarks run (though I'll make a silly change to a source file to test them).

I'll mark as ready after I've tested.

This change enables us to only run benchmarks on PRs that change files relevant to the benchmarks
@coveralls
Copy link

coveralls commented Jan 20, 2021

Coverage Status

Coverage remained the same at 99.439% when pulling c363f98 on separate-benchmark-workflow into 8d3bbec on master.

@github-actions
Copy link

github-actions bot commented Jan 20, 2021

Size Change: 0 B

Total Size: 41.9 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 3.93 kB 0 B
dist/preact.min.js 3.96 kB 0 B
dist/preact.module.js 3.96 kB 0 B
dist/preact.umd.js 4 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Jan 20, 2021

📊 Tachometer Benchmark Results

Summary

Results

tachometer-reporter-action v2 for Benchmarks

@andrewiggins
Copy link
Member Author

(I cancelled the benchmarks to not use our API limits since this is just a test that they are invoked)

@andrewiggins andrewiggins marked this pull request as ready for review January 20, 2021 07:54
@andrewiggins andrewiggins merged commit 4581dc8 into master Jan 20, 2021
@andrewiggins andrewiggins deleted the separate-benchmark-workflow branch January 20, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants