Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Alias react to preact/compat #2946

Merged
merged 2 commits into from Jan 20, 2021
Merged

Tests: Alias react to preact/compat #2946

merged 2 commits into from Jan 20, 2021

Conversation

marvinhagemeister
Copy link
Member

It's way more fun to debug react a compatibility with libraries without all the webpack noise. So I wondered if we can use our new esbuild setup in our test suite instead of our demo app for that. And it works for me.

@github-actions
Copy link

github-actions bot commented Jan 20, 2021 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -0% - +1% (-0.17ms - +2.40ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +4% (-1.43ms - +1.28ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-6.83ms - +16.06ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +7% (-0.49ms - +2.18ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +5% (-3.96ms - +8.45ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -2% - +12% (-0.73ms - +3.88ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +5% (-0.18ms - +0.17ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 70
  • Built by: CI #760

  • Commit: d6ff340

duration

VersionAvg timevs preact-mastervs preact-local
preact-master173.38ms - 174.78ms-unsure 🔍
-1% - +0%
-2.40ms - +0.17ms
preact-local174.11ms - 176.27msunsure 🔍
-0% - +1%
-0.17ms - +2.40ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.59ms - 3.59ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local3.59ms - 3.60msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master65.10ms - 67.00ms-unsure 🔍
-1% - +2%
-0.97ms - +1.57ms
preact-local64.91ms - 66.59msunsure 🔍
-2% - +1%
-1.57ms - +0.97ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master101.07ms - 102.85ms-unsure 🔍
-1% - +1%
-0.86ms - +1.39ms
preact-local101.01ms - 102.38msunsure 🔍
-1% - +1%
-1.39ms - +0.86ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master117.51ms - 119.44ms-unsure 🔍
-1% - +2%
-1.06ms - +2.49ms
preact-local116.27ms - 119.25msunsure 🔍
-2% - +1%
-2.49ms - +1.06ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master64.23ms - 65.07ms-unsure 🔍
-3% - +0%
-2.07ms - +0.32ms
preact-local64.41ms - 66.64msunsure 🔍
-0% - +3%
-0.32ms - +2.07ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master127.99ms - 130.70ms-unsure 🔍
-2% - +1%
-1.99ms - +1.64ms
preact-local128.31ms - 130.72msunsure 🔍
-1% - +2%
-1.64ms - +1.99ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master63.52ms - 64.33ms-unsure 🔍
-2% - +0%
-1.12ms - +0.18ms
preact-local63.89ms - 64.91msunsure 🔍
-0% - +2%
-0.18ms - +1.12ms		-
03_update10th1k_x16
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #760

  • Commit: d6ff340

duration

VersionAvg timevs preact-mastervs preact-local
preact-master29.52ms - 31.50ms-unsure 🔍
-4% - +5%
-1.28ms - +1.43ms
preact-local29.51ms - 31.37msunsure 🔍
-5% - +4%
-1.43ms - +1.28ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.51ms - 3.52ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.51ms - 3.52msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-
07_create10k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 50
  • Built by: CI #760

  • Commit: d6ff340

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1636.86ms - 1653.60ms-unsure 🔍
-1% - +0%
-16.06ms - +6.83ms
preact-local1642.04ms - 1657.66msunsure 🔍
-0% - +1%
-6.83ms - +16.06ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.98ms - 25.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.98ms - 25.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter_list
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #760

  • Commit: d6ff340

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.92ms - 33.72ms-unsure 🔍
-6% - +1%
-2.18ms - +0.49ms
preact-local32.67ms - 34.65msunsure 🔍
-2% - +7%
-0.49ms - +2.18ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.60ms - 1.60ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.60ms - 1.60msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 60
  • Built by: CI #760

  • Commit: d6ff340

duration

VersionAvg timevs preact-mastervs preact-local
preact-master165.50ms - 174.55ms-unsure 🔍
-5% - +2%
-8.45ms - +3.96ms
preact-local168.02ms - 176.51msunsure 🔍
-2% - +5%
-3.96ms - +8.45ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.19ms - 6.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.19ms - 6.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #760

  • Commit: d6ff340

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.85ms - 34.66ms-unsure 🔍
-11% - +2%
-3.88ms - +0.73ms
preact-local33.00ms - 36.66msunsure 🔍
-2% - +12%
-0.73ms - +3.88ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.84ms - 4.84ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.84ms - 4.84msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
text_update
  • Browser: chrome-headless 87.0.4280.88
  • Sample size: 80
  • Built by: CI #760

  • Commit: d6ff340

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.55ms - 3.79ms-unsure 🔍
-5% - +5%
-0.17ms - +0.18ms
preact-local3.54ms - 3.80msunsure 🔍
-5% - +5%
-0.18ms - +0.17ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.83ms - 0.83ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local0.83ms - 0.83msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

tachometer-reporter-action v2 for CI

@coveralls
Copy link

coveralls commented Jan 20, 2021 •
edited

Coverage Status

Coverage remained the same at 99.439% when pulling 01b3b41 on react-alias into 4581dc8 on master.

@github-actions
Copy link

github-actions bot commented Jan 20, 2021 •
edited

Size Change: 0 B

Total Size: 41.9 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.45 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.51 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 186 B 0 B
devtools/dist/devtools.module.js 196 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 3.93 kB 0 B
dist/preact.min.js 3.96 kB 0 B
dist/preact.module.js 3.96 kB 0 B
dist/preact.umd.js 4 kB 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 33183c8 into master Jan 20, 2021
@marvinhagemeister marvinhagemeister deleted the react-alias branch January 20, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhagemeister @coveralls @developit