Fix HTML comments breaking hydration

[marvinhagemeister]

This PR resolves a regression when react-dom/server was used to render a Preact app instead of preact-render-to-string. It was introduced in #2942 and reverts a part of it to what it was like before.

Fixes #2950 .

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• 02_replace1k: unsure 🔍 -0% - +1% (-0.46ms - +1.44ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: unsure 🔍 -4% - +4% (-1.44ms - +1.50ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -1% - +1% (-18.53ms - +16.41ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -0% - +5% (-0.10ms - +1.14ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -1% - +0% (-1.02ms - +0.57ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -6% - +6% (-2.34ms - +2.30ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 -2% - +2% (-0.08ms - +0.07ms)
  ^{preact-local vs preact-master}

usedJSHeapSize

• 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-master}
• 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-master}
• 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-master}
• text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-master}

Results

02_replace1k

• Browser: chrome-headless 87.0.4280.88
• Sample size: 50
• Built by: Benchmarks #8

• Commit: 2132280

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	151.99ms - 153.22ms	-	unsure 🔍 -1% - +0% -1.44ms - +0.46ms
preact-local	152.36ms - 153.82ms	unsure 🔍 -0% - +1% -0.46ms - +1.44ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.59ms - 3.60ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.01ms
preact-local	3.59ms - 3.60ms	unsure 🔍 -0% - +0% -0.01ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-master	vs preact-local
preact-master	55.64ms - 56.21ms	-	unsure 🔍 -1% - +1% -0.65ms - +0.41ms
preact-local	55.59ms - 56.49ms	unsure 🔍 -1% - +1% -0.41ms - +0.65ms	-

run-warmup-1

Version	Avg time	vs preact-master	vs preact-local
preact-master	87.30ms - 88.41ms	-	unsure 🔍 -1% - +1% -1.21ms - +0.77ms
preact-local	87.25ms - 88.89ms	unsure 🔍 -1% - +1% -0.77ms - +1.21ms	-

run-warmup-2

Version	Avg time	vs preact-master	vs preact-local
preact-master	101.48ms - 102.65ms	-	unsure 🔍 -1% - +1% -0.93ms - +0.73ms
preact-local	101.57ms - 102.76ms	unsure 🔍 -1% - +1% -0.73ms - +0.93ms	-

run-warmup-3

Version	Avg time	vs preact-master	vs preact-local
preact-master	56.71ms - 57.33ms	-	unsure 🔍 -1% - +0% -0.65ms - +0.19ms
preact-local	56.97ms - 57.53ms	unsure 🔍 -0% - +1% -0.19ms - +0.65ms	-

run-warmup-4

Version	Avg time	vs preact-master	vs preact-local
preact-master	110.54ms - 112.28ms	-	unsure 🔍 -1% - +1% -1.34ms - +1.12ms
preact-local	110.66ms - 112.39ms	unsure 🔍 -1% - +1% -1.12ms - +1.34ms	-

run-final

Version	Avg time	vs preact-master	vs preact-local
preact-master	55.88ms - 56.12ms	-	unsure 🔍 -1% - +0% -0.32ms - +0.07ms
preact-local	55.97ms - 56.28ms	unsure 🔍 -0% - +1% -0.07ms - +0.32ms	-

03_update10th1k_x16

• Browser: chrome-headless 87.0.4280.88
• Sample size: 80
• Built by: Benchmarks #8

• Commit: 2132280

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	33.83ms - 35.75ms	-	unsure 🔍 -4% - +4% -1.50ms - +1.44ms
preact-local	33.70ms - 35.94ms	unsure 🔍 -4% - +4% -1.44ms - +1.50ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.51ms - 3.52ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.01ms
preact-local	3.51ms - 3.52ms	unsure 🔍 -0% - +0% -0.01ms - +0.00ms	-

07_create10k

• Browser: chrome-headless 87.0.4280.88
• Sample size: 50
• Built by: Benchmarks #8

• Commit: 2132280

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	1592.90ms - 1618.52ms	-	unsure 🔍 -1% - +1% -16.41ms - +18.53ms
preact-local	1592.78ms - 1616.54ms	unsure 🔍 -1% - +1% -18.53ms - +16.41ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	25.99ms - 25.99ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	25.98ms - 25.99ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter_list

• Browser: chrome-headless 87.0.4280.88
• Sample size: 60
• Built by: Benchmarks #8

• Commit: 2132280

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	23.10ms - 23.95ms	-	unsure 🔍 -5% - +0% -1.14ms - +0.10ms
preact-local	23.60ms - 24.49ms	unsure 🔍 -0% - +5% -0.10ms - +1.14ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.60ms - 1.60ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	1.60ms - 1.60ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

• Browser: chrome-headless 87.0.4280.88
• Sample size: 50
• Built by: Benchmarks #8

• Commit: 2132280

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	135.47ms - 136.70ms	-	unsure 🔍 -0% - +1% -0.57ms - +1.02ms
preact-local	135.35ms - 136.37ms	unsure 🔍 -1% - +0% -1.02ms - +0.57ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	6.19ms - 6.19ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	6.19ms - 6.19ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

many_updates

• Browser: chrome-headless 87.0.4280.88
• Sample size: 80
• Built by: Benchmarks #8

• Commit: 2132280

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	38.72ms - 41.99ms	-	unsure 🔍 -6% - +6% -2.30ms - +2.34ms
preact-local	38.69ms - 41.98ms	unsure 🔍 -6% - +6% -2.34ms - +2.30ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.84ms - 4.84ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	4.84ms - 4.84ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

text_update

• Browser: chrome-headless 87.0.4280.88
• Sample size: 50
• Built by: Benchmarks #8

• Commit: 2132280

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.42ms - 3.55ms	-	unsure 🔍 -2% - +2% -0.07ms - +0.08ms
preact-local	3.43ms - 3.52ms	unsure 🔍 -2% - +2% -0.08ms - +0.07ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	0.83ms - 0.83ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	0.83ms - 0.83ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[coveralls]

Coverage remained the same at 99.44% when pulling 5583b46 on hydration-comment into 359ad4f on master.

[github-actions]

Size Change: +53 B (0%)

Total Size: 42.1 kB

Filename	Size	Change
dist/preact.js	3.95 kB	+13 B (0%)
dist/preact.min.js	3.98 kB	+13 B (0%)
dist/preact.module.js	3.98 kB	+14 B (0%)
dist/preact.umd.js	4.02 kB	+13 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
compat/dist/compat.js	3.45 kB	0 B
compat/dist/compat.module.js	3.47 kB	0 B
compat/dist/compat.umd.js	3.51 kB	0 B
debug/dist/debug.js	2.99 kB	0 B
debug/dist/debug.module.js	2.98 kB	0 B
debug/dist/debug.umd.js	3.07 kB	0 B
devtools/dist/devtools.js	232 B	0 B
devtools/dist/devtools.module.js	240 B	0 B
devtools/dist/devtools.umd.js	308 B	0 B
hooks/dist/hooks.js	1.13 kB	0 B
hooks/dist/hooks.module.js	1.15 kB	0 B
hooks/dist/hooks.umd.js	1.2 kB	0 B
jsx-runtime/dist/jsxRuntime.js	327 B	0 B
jsx-runtime/dist/jsxRuntime.module.js	335 B	0 B
jsx-runtime/dist/jsxRuntime.umd.js	405 B	0 B
test-utils/dist/testUtils.js	437 B	0 B
test-utils/dist/testUtils.module.js	439 B	0 B
test-utils/dist/testUtils.umd.js	515 B	0 B

_{compressed-size-action}