Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server.browser.js #3544

Merged
merged 2 commits into from May 29, 2022
Merged

add server.browser.js #3544

merged 2 commits into from May 29, 2022

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented May 17, 2022

comply with react's new server file, all though they export CJS and we do ESM https://www.runpkg.com/?react-dom@18.1.0/server.browser.js

Fixes #3543

@coveralls
Copy link

coveralls commented May 17, 2022

Coverage Status

Coverage remained the same at 99.44% when pulling f406bbc on browser-server into 43d79c0 on master.

@JoviDeCroock JoviDeCroock merged commit 4e34efe into master May 29, 2022
@JoviDeCroock JoviDeCroock deleted the browser-server branch May 29, 2022 10:06
@danielbarion
Copy link

Looking forward to the next release with that MR to upgrade next.js to the latest version. Thank you guys!

@MarianDabrowski
Copy link

Cannot wait for the new release!

@adhirajsinghchauhan
Copy link

preactjs/compat-alias-package needs to be updated for this as well

@JoviDeCroock
Copy link
Member Author

@adhirajsinghchauhan PR's welcomed

@adhirajsinghchauhan
Copy link

Sorry for not checking in earlier. I see that preactjs/compat-alias-package#5 was merged, though preactjs/compat-alias-package#6 was indeed the correct "fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preact/compat is missing server.browser.js
6 participants