Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid crashing due to __hooks being null #3651

Merged
merged 2 commits into from Aug 7, 2022

Conversation

JoviDeCroock
Copy link
Member

fixes #3647

When suspending we reset __hooks to null, when this happens we should update rather than crashing 馃槄

@coveralls
Copy link

coveralls commented Aug 7, 2022

Coverage Status

Coverage decreased (-0.2%) to 99.287% when pulling 0dfff5c on avoid-suspense-hooks-reset-crash into 191d5cb on master.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Size Change: +23 B (0%)

Total Size: 43.7 kB

Filename Size Change
hooks/dist/hooks.js 1.38 kB +7 B (0%)
hooks/dist/hooks.module.js 1.41 kB +9 B (0%)
hooks/dist/hooks.umd.js 1.47 kB +7 B (0%)
鈩癸笍 View Unchanged
Filename Size Change
compat/dist/compat.js 3.67 kB 0 B
compat/dist/compat.module.js 3.65 kB 0 B
compat/dist/compat.umd.js 3.73 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 229 B 0 B
devtools/dist/devtools.module.js 238 B 0 B
devtools/dist/devtools.umd.js 305 B 0 B
dist/preact.js 4 kB 0 B
dist/preact.min.js 4.03 kB 0 B
dist/preact.module.js 4.02 kB 0 B
dist/preact.umd.js 4.06 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 馃槑

@marvinhagemeister marvinhagemeister merged commit d483611 into master Aug 7, 2022
@marvinhagemeister marvinhagemeister deleted the avoid-suspense-hooks-reset-crash branch August 7, 2022 17:33
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Cannot read properties of null (reading '__')" error when suspending the entire app
4 participants