Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync-external-store with zustand #3663

Merged
merged 3 commits into from Aug 12, 2022
Merged

fix sync-external-store with zustand #3663

merged 3 commits into from Aug 12, 2022

Conversation

JoviDeCroock
Copy link
Member

fixes #3662

When zustand is used they use the withSelector variant of sync-external-store. This relies on getSnapshot not being incorporated in the useEffect dependency array.

Creating a test for it atm

@coveralls
Copy link

coveralls commented Aug 11, 2022

Coverage Status

Coverage decreased (-0.001%) to 99.29% when pulling d5064cb on fix-ext-store into 6b92b1f on master.

@github-actions
Copy link

github-actions bot commented Aug 11, 2022

Size Change: +66 B (0%)

Total Size: 43.9 kB

Filename Size Change
compat/dist/compat.js 3.72 kB +23 B (0%)
compat/dist/compat.module.js 3.7 kB +25 B (0%)
compat/dist/compat.umd.js 3.78 kB +18 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 306 B 0 B
dist/preact.js 4 kB 0 B
dist/preact.min.js 4.03 kB 0 B
dist/preact.module.js 4.02 kB 0 B
dist/preact.umd.js 4.06 kB 0 B
hooks/dist/hooks.js 1.38 kB 0 B
hooks/dist/hooks.module.js 1.41 kB 0 B
hooks/dist/hooks.umd.js 1.47 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JoviDeCroock JoviDeCroock merged commit b9f6446 into master Aug 12, 2022
@JoviDeCroock JoviDeCroock deleted the fix-ext-store branch August 12, 2022 07:26
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 12, 2022
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
* backport #3615

* backport #3633

* backport #3643

* backport #3655

* backport #3663

* backport #3690

* backport useState optim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop when using zustand
3 participants