Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve types for bare createElement and h calls #3690

Merged
merged 5 commits into from Aug 24, 2022
Merged

improve types for bare createElement and h calls #3690

merged 5 commits into from Aug 24, 2022

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 24, 2022 •
edited

Resolves #3618
Resolves #2612

This fine-tunes the element creation calls to derive more state from the context in which they are called. This also makes a special case for input so we can correctly leverage onInput

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.291% when pulling 4f11884 on create-element-h-types into 14977dd on master.

marvinhagemeister
marvinhagemeister approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@JoviDeCroock JoviDeCroock merged commit 1633907 into master Aug 24, 2022
@JoviDeCroock JoviDeCroock deleted the create-element-h-types branch August 24, 2022 12:33
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
@JoviDeCroock
backport #3690
8af20c0
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
@JoviDeCroock
Backports x (#3707)
aa8d57b 
* backport #3615

* backport #3633

* backport #3643

* backport #3655

* backport #3663

* backport #3690

* backport useState optim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@JoviDeCroock @coveralls @marvinhagemeister