Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add todo benchmark and add a proxy package that uses preact/hooks #3708

Merged
merged 6 commits into from Sep 2, 2022
Merged

add todo benchmark and add a proxy package that uses preact/hooks #3708

merged 6 commits into from Sep 2, 2022

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Sep 2, 2022 •
edited

Coverage Status

Coverage remained the same at 99.522% when pulling b749474 on todo-benchmark into e70238f on master.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited

Size Change: 0 B

Total Size: 52.3 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.77 kB 0 B
compat/dist/compat.module.js 3.71 kB 0 B
compat/dist/compat.umd.js 3.84 kB 0 B
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.js 4.01 kB 0 B
dist/preact.min.js 4.04 kB 0 B
dist/preact.min.module.js 4.04 kB 0 B
dist/preact.min.umd.js 4.07 kB 0 B
dist/preact.module.js 4.03 kB 0 B
dist/preact.umd.js 4.08 kB 0 B
hooks/dist/hooks.js 1.4 kB 0 B
hooks/dist/hooks.module.js 1.43 kB 0 B
hooks/dist/hooks.umd.js 1.48 kB 0 B
jsx-runtime/dist/jsxRuntime.js 358 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 324 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 439 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@preactjs preactjs deleted a comment from github-actions bot Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -5% - +3% (-7.05ms - +3.81ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -3% - +2% (-1.57ms - +0.95ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +2% (-3.19ms - +34.45ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +4% (-0.09ms - +0.95ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +1% (-3.68ms - +2.67ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -4% - +3% (-0.90ms - +0.77ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +1% (-0.22ms - +0.04ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -2% - +2% (-1.25ms - +1.24ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -2% - +4% (-0.08ms - +0.16ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -1% - +1% (-0.03ms - +0.02ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.02ms - +0.02ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -1% - +2% (-0.01ms - +0.03ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master140.58ms - 147.06ms-unsure 🔍
-3% - +5%
-3.81ms - +7.05ms		unsure 🔍
-2% - +7%
-2.70ms - +9.45ms
preact-local137.83ms - 146.55msunsure 🔍
-5% - +3%
-7.05ms - +3.81ms		-unsure 🔍
-4% - +6%
-4.99ms - +8.49ms
preact-hooks135.30ms - 145.58msunsure 🔍
-7% - +2%
-9.45ms - +2.70ms		unsure 🔍
-6% - +3%
-8.49ms - +4.99ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.74ms - 3.88ms-unsure 🔍
-4% - +2%
-0.16ms - +0.08ms		unsure 🔍
-6% - +1%
-0.23ms - +0.05ms
preact-local3.75ms - 3.95msunsure 🔍
-2% - +4%
-0.08ms - +0.16ms		-unsure 🔍
-5% - +2%
-0.20ms - +0.10ms
preact-hooks3.78ms - 4.02msunsure 🔍
-1% - +6%
-0.05ms - +0.23ms		unsure 🔍
-3% - +5%
-0.10ms - +0.20ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.22ms - 1.29ms-unsure 🔍
-1% - +6%
-0.02ms - +0.07ms		unsure 🔍
-1% - +6%
-0.01ms - +0.08ms
preact-local1.20ms - 1.25msunsure 🔍
-6% - +1%
-0.07ms - +0.02ms		-unsure 🔍
-3% - +3%
-0.03ms - +0.04ms
preact-hooks1.19ms - 1.25msunsure 🔍
-6% - +1%
-0.08ms - +0.01ms		unsure 🔍
-3% - +3%
-0.04ms - +0.03ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.66ms - 1.01ms-unsure 🔍
-39% - +12%
-0.40ms - +0.13ms		unsure 🔍
-21% - +37%
-0.16ms - +0.28ms
preact-local0.77ms - 1.16msunsure 🔍
-18% - +50%
-0.13ms - +0.40ms		-unsure 🔍
-7% - +57%
-0.04ms - +0.42ms
preact-hooks0.65ms - 0.90msunsure 🔍
-32% - +18%
-0.28ms - +0.16ms		unsure 🔍
-41% - +1%
-0.42ms - +0.04ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.76ms - 0.91ms-unsure 🔍
-16% - +12%
-0.14ms - +0.10ms		unsure 🔍
-22% - +5%
-0.21ms - +0.05ms
preact-local0.76ms - 0.95msunsure 🔍
-13% - +17%
-0.10ms - +0.14ms		-unsure 🔍
-22% - +9%
-0.20ms - +0.08ms
preact-hooks0.80ms - 1.02msunsure 🔍
-7% - +25%
-0.05ms - +0.21ms		unsure 🔍
-10% - +24%
-0.08ms - +0.20ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.42ms - 0.48ms-unsure 🔍
-10% - +7%
-0.04ms - +0.03ms		unsure 🔍
-4% - +13%
-0.02ms - +0.05ms
preact-local0.43ms - 0.48msunsure 🔍
-7% - +10%
-0.03ms - +0.04ms		-unsure 🔍
-2% - +14%
-0.01ms - +0.06ms
preact-hooks0.41ms - 0.45msunsure 🔍
-12% - +4%
-0.05ms - +0.02ms		unsure 🔍
-13% - +2%
-0.06ms - +0.01ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.56ms - 1.18ms-unsure 🔍
-31% - +71%
-0.20ms - +0.50ms		unsure 🔍
-26% - +75%
-0.17ms - +0.51ms
preact-local0.56ms - 0.88msunsure 🔍
-52% - +18%
-0.50ms - +0.20ms		-unsure 🔍
-27% - +34%
-0.19ms - +0.23ms
preact-hooks0.56ms - 0.83msunsure 🔍
-52% - +13%
-0.51ms - +0.17ms		unsure 🔍
-32% - +25%
-0.23ms - +0.19ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.37ms - 0.47ms-unsure 🔍
-11% - +21%
-0.04ms - +0.08ms		unsure 🔍
-24% - +3%
-0.12ms - +0.02ms
preact-local0.36ms - 0.44msunsure 🔍
-19% - +10%
-0.08ms - +0.04ms		-faster ✔
3% - 26%
0.01ms - 0.13ms
preact-hooks0.43ms - 0.52msunsure 🔍
-5% - +28%
-0.02ms - +0.12ms		slower ❌
2% - 33%
0.01ms - 0.13ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master46.51ms - 48.27ms-unsure 🔍
-2% - +3%
-0.95ms - +1.57ms		unsure 🔍
-4% - +2%
-1.95ms - +0.75ms
preact-local46.18ms - 47.98msunsure 🔍
-3% - +2%
-1.57ms - +0.95ms		-unsure 🔍
-5% - +1%
-2.27ms - +0.45ms
preact-hooks46.97ms - 49.01msunsure 🔍
-2% - +4%
-0.75ms - +1.95ms		unsure 🔍
-1% - +5%
-0.45ms - +2.27ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.74ms - 3.77ms-unsure 🔍
-1% - +1%
-0.02ms - +0.03ms		unsure 🔍
-1% - +0%
-0.04ms - +0.01ms
preact-local3.73ms - 3.77msunsure 🔍
-1% - +1%
-0.03ms - +0.02ms		-unsure 🔍
-1% - +0%
-0.04ms - +0.01ms
preact-hooks3.75ms - 3.79msunsure 🔍
-0% - +1%
-0.01ms - +0.04ms		unsure 🔍
-0% - +1%
-0.01ms - +0.04ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1828.15ms - 1852.50ms-unsure 🔍
-2% - +0%
-34.45ms - +3.19ms		unsure 🔍
-1% - +1%
-27.04ms - +11.10ms
preact-local1841.60ms - 1870.30msunsure 🔍
-0% - +2%
-3.19ms - +34.45ms		-unsure 🔍
-1% - +2%
-12.87ms - +28.18ms
preact-hooks1833.62ms - 1862.97msunsure 🔍
-1% - +1%
-11.10ms - +27.04ms		unsure 🔍
-2% - +1%
-28.18ms - +12.87ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.59ms - 25.59ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.59ms - 25.59msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.60ms - 25.60msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master22.50ms - 23.05ms-unsure 🔍
-4% - +0%
-0.95ms - +0.09ms		unsure 🔍
-3% - +1%
-0.66ms - +0.31ms
preact-local22.76ms - 23.64msunsure 🔍
-0% - +4%
-0.09ms - +0.95ms		-unsure 🔍
-2% - +4%
-0.34ms - +0.84ms
preact-hooks22.56ms - 23.35msunsure 🔍
-1% - +3%
-0.31ms - +0.66ms		unsure 🔍
-4% - +1%
-0.84ms - +0.34ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.81ms - 1.81ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local1.81ms - 1.81msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.83ms - 1.84msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master194.05ms - 198.25ms-unsure 🔍
-1% - +2%
-2.67ms - +3.68ms		unsure 🔍
-1% - +2%
-2.58ms - +3.48ms
preact-local193.26ms - 198.02msunsure 🔍
-2% - +1%
-3.68ms - +2.67ms		-unsure 🔍
-2% - +2%
-3.29ms - +3.18ms
preact-hooks193.51ms - 197.88msunsure 🔍
-2% - +1%
-3.48ms - +2.58ms		unsure 🔍
-2% - +2%
-3.18ms - +3.29ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master6.40ms - 6.42ms-unsure 🔍
-0% - +0%
-0.02ms - +0.02ms		faster ✔
0% - 1%
0.02ms - 0.05ms
preact-local6.40ms - 6.42msunsure 🔍
-0% - +0%
-0.02ms - +0.02ms		-faster ✔
0% - 1%
0.02ms - 0.05ms
preact-hooks6.43ms - 6.46msslower ❌
0% - 1%
0.02ms - 0.05ms		slower ❌
0% - 1%
0.02ms - 0.05ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.01ms - 26.18ms-unsure 🔍
-3% - +4%
-0.77ms - +0.90ms		unsure 🔍
-4% - +3%
-0.95ms - +0.68ms
preact-local24.93ms - 26.13msunsure 🔍
-4% - +3%
-0.90ms - +0.77ms		-unsure 🔍
-4% - +2%
-1.03ms - +0.63ms
preact-hooks25.16ms - 26.30msunsure 🔍
-3% - +4%
-0.68ms - +0.95ms		unsure 🔍
-2% - +4%
-0.63ms - +1.03ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.88ms - 4.88ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.88ms - 4.88msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.90ms - 4.90msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.80ms - 4.02ms-unsure 🔍
-1% - +6%
-0.04ms - +0.22ms		faster ✔
2% - 8%
0.08ms - 0.34ms
preact-local3.76ms - 3.89msunsure 🔍
-5% - +1%
-0.22ms - +0.04ms		-faster ✔
5% - 9%
0.20ms - 0.39ms
preact-hooks4.05ms - 4.19msslower ❌
2% - 9%
0.08ms - 0.34ms		slower ❌
5% - 10%
0.20ms - 0.39ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.05ms - 1.05ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.01ms - 0.01ms
preact-local1.05ms - 1.05msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.01ms - 0.01ms
preact-hooks1.06ms - 1.06msslower ❌
1% - 1%
0.01ms - 0.01ms		slower ❌
1% - 1%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master51.35ms - 53.11ms-unsure 🔍
-2% - +2%
-1.24ms - +1.25ms		unsure 🔍
-5% - +0%
-2.56ms - +0.06ms
preact-local51.34ms - 53.11msunsure 🔍
-2% - +2%
-1.25ms - +1.24ms		-unsure 🔍
-5% - +0%
-2.57ms - +0.05ms
preact-hooks52.51ms - 54.45msunsure 🔍
-0% - +5%
-0.06ms - +2.56ms		unsure 🔍
-0% - +5%
-0.05ms - +2.57ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.41ms - 1.44ms-unsure 🔍
-2% - +1%
-0.03ms - +0.01ms		slower ❌
1% - 4%
0.01ms - 0.05ms
preact-local1.42ms - 1.45msunsure 🔍
-1% - +2%
-0.01ms - +0.03ms		-slower ❌
1% - 4%
0.02ms - 0.06ms
preact-hooks1.38ms - 1.41msfaster ✔
1% - 4%
0.01ms - 0.05ms		faster ✔
1% - 4%
0.02ms - 0.06ms		-

tachometer-reporter-action v2 for Benchmarks

@marvinhagemeister marvinhagemeister merged commit 1427d58 into master Sep 2, 2022
@marvinhagemeister marvinhagemeister deleted the todo-benchmark branch September 2, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoviDeCroock @coveralls @marvinhagemeister