Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade workflow actions #3777

Merged
merged 5 commits into from Oct 27, 2022
Merged

Upgrade workflow actions #3777

merged 5 commits into from Oct 27, 2022

Conversation

andrewiggins
Copy link
Member

Upgrade the versions of the actions in our workflows to newer version and take advantage of some new features.

  • Specify the our desired version of node in the root package.json using the "volta" key
  • Specify all actions to use the node version specified in the volta key of the package.json (setup-node action docs for this feature)
  • Use the setup-node built-in cache capability for npm to simplify our workflows

@coveralls
Copy link

coveralls commented Oct 25, 2022 •
edited

Coverage Status

Coverage remained the same at 99.531% when pulling b0ff453 on upgrade-workflows into b1549ee on master.

@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -6% - +9% (-8.62ms - +13.14ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +2% (-1.96ms - +1.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-7.27ms - +6.42ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +5% (-0.19ms - +1.58ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +1% (-2.04ms - +0.83ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -2% - +4% (-0.36ms - +0.99ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +1% (-0.02ms - +0.03ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -1% - +4% (-0.55ms - +2.11ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -9% - +2% (-0.39ms - +0.10ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +5% (-0.42ms - +0.74ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master141.70ms - 158.72ms-unsure 🔍
-9% - +6%
-13.14ms - +8.62ms		unsure 🔍
-4% - +16%
-4.75ms - +22.20ms
preact-local145.68ms - 159.25msunsure 🔍
-6% - +9%
-8.62ms - +13.14ms		-unsure 🔍
-2% - +17%
-1.47ms - +23.44ms
preact-hooks131.04ms - 151.93msunsure 🔍
-15% - +3%
-22.20ms - +4.75ms		unsure 🔍
-15% - +1%
-23.44ms - +1.47ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.04ms - 4.43ms-unsure 🔍
-3% - +10%
-0.10ms - +0.39ms		unsure 🔍
-13% - +1%
-0.62ms - +0.04ms
preact-local3.94ms - 4.24msunsure 🔍
-9% - +2%
-0.39ms - +0.10ms		-faster ✔
3% - 16%
0.13ms - 0.74ms
preact-hooks4.26ms - 4.80msunsure 🔍
-1% - +15%
-0.04ms - +0.62ms		slower ❌
3% - 18%
0.13ms - 0.74ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.25ms - 1.37ms-unsure 🔍
-2% - +13%
-0.03ms - +0.15ms		unsure 🔍
-12% - +8%
-0.16ms - +0.11ms
preact-local1.18ms - 1.31msunsure 🔍
-12% - +2%
-0.15ms - +0.03ms		-unsure 🔍
-16% - +3%
-0.23ms - +0.04ms
preact-hooks1.22ms - 1.46msunsure 🔍
-8% - +12%
-0.11ms - +0.16ms		unsure 🔍
-4% - +18%
-0.04ms - +0.23ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.89ms - 1.21ms-unsure 🔍
-17% - +24%
-0.17ms - +0.24ms		unsure 🔍
-20% - +26%
-0.20ms - +0.26ms
preact-local0.89ms - 1.15msunsure 🔍
-22% - +16%
-0.24ms - +0.17ms		-unsure 🔍
-21% - +21%
-0.21ms - +0.21ms
preact-hooks0.86ms - 1.19msunsure 🔍
-25% - +19%
-0.26ms - +0.20ms		unsure 🔍
-21% - +21%
-0.21ms - +0.21ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.49ms - 0.59ms-unsure 🔍
-14% - +16%
-0.08ms - +0.09ms		unsure 🔍
-7% - +19%
-0.03ms - +0.09ms
preact-local0.48ms - 0.60msunsure 🔍
-16% - +14%
-0.09ms - +0.08ms		-unsure 🔍
-9% - +19%
-0.04ms - +0.10ms
preact-hooks0.48ms - 0.55msunsure 🔍
-17% - +6%
-0.09ms - +0.03ms		unsure 🔍
-17% - +8%
-0.10ms - +0.04ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.44ms - 0.98ms-unsure 🔍
-2% - +117%
-0.01ms - +0.53ms		faster ✔
17% - 73%
0.06ms - 1.12ms
preact-local0.43ms - 0.47msunsure 🔍
-60% - -12%
-0.53ms - +0.01ms		-faster ✔
53% - 78%
0.39ms - 1.31ms
preact-hooks0.84ms - 1.76msunsure 🔍
-11% - +177%
+0.06ms - +1.12ms		slower ❌
86% - 290%
0.39ms - 1.31ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.35ms - 0.42ms-unsure 🔍
-18% - +8%
-0.08ms - +0.04ms		unsure 🔍
-22% - +2%
-0.10ms - +0.01ms
preact-local0.36ms - 0.45msunsure 🔍
-10% - +20%
-0.04ms - +0.08ms		-unsure 🔍
-19% - +9%
-0.08ms - +0.04ms
preact-hooks0.38ms - 0.47msunsure 🔍
-4% - +25%
-0.01ms - +0.10ms		unsure 🔍
-10% - +21%
-0.04ms - +0.08ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.40ms - 0.49ms-unsure 🔍
-18% - +14%
-0.08ms - +0.06ms		unsure 🔍
-6% - +21%
-0.02ms - +0.08ms
preact-local0.40ms - 0.51msunsure 🔍
-14% - +19%
-0.06ms - +0.08ms		-unsure 🔍
-7% - +26%
-0.03ms - +0.11ms
preact-hooks0.38ms - 0.45msunsure 🔍
-18% - +5%
-0.08ms - +0.02ms		unsure 🔍
-23% - +5%
-0.11ms - +0.03ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master40.73ms - 42.89ms-unsure 🔍
-2% - +5%
-1.01ms - +1.96ms		unsure 🔍
-2% - +5%
-0.86ms - +2.03ms
preact-local40.32ms - 42.35msunsure 🔍
-5% - +2%
-1.96ms - +1.01ms		-unsure 🔍
-3% - +4%
-1.28ms - +1.50ms
preact-hooks40.27ms - 42.18msunsure 🔍
-5% - +2%
-2.03ms - +0.86ms		unsure 🔍
-4% - +3%
-1.50ms - +1.28ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.78ms - 3.78ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.78ms - 3.78msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.79ms - 3.80msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1243.31ms - 1252.95ms-unsure 🔍
-1% - +1%
-6.42ms - +7.27ms		unsure 🔍
-1% - +0%
-10.30ms - +2.62ms
preact-local1242.84ms - 1252.56msunsure 🔍
-1% - +1%
-7.27ms - +6.42ms		-unsure 🔍
-1% - +0%
-10.75ms - +2.22ms
preact-hooks1247.68ms - 1256.26msunsure 🔍
-0% - +1%
-2.62ms - +10.30ms		unsure 🔍
-0% - +1%
-2.22ms - +10.75ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.84ms - 25.84ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.84ms - 25.84msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.86ms - 25.86msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master28.33ms - 29.20ms-unsure 🔍
-5% - +1%
-1.58ms - +0.19ms		unsure 🔍
-3% - +1%
-0.90ms - +0.33ms
preact-local28.69ms - 30.23msunsure 🔍
-1% - +5%
-0.19ms - +1.58ms		-unsure 🔍
-2% - +4%
-0.47ms - +1.29ms
preact-hooks28.62ms - 29.48msunsure 🔍
-1% - +3%
-0.33ms - +0.90ms		unsure 🔍
-4% - +2%
-1.29ms - +0.47ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.93ms - 1.93ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.93ms - 1.93msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.95ms - 1.95msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master137.28ms - 139.20ms-unsure 🔍
-1% - +1%
-0.83ms - +2.04ms		unsure 🔍
-1% - +1%
-1.32ms - +1.51ms
preact-local136.57ms - 138.70msunsure 🔍
-1% - +1%
-2.04ms - +0.83ms		-unsure 🔍
-1% - +1%
-2.00ms - +0.97ms
preact-hooks137.11ms - 139.18msunsure 🔍
-1% - +1%
-1.51ms - +1.32ms		unsure 🔍
-1% - +1%
-0.97ms - +2.00ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master14.42ms - 15.28ms-unsure 🔍
-5% - +3%
-0.74ms - +0.42ms		unsure 🔍
-4% - +4%
-0.62ms - +0.56ms
preact-local14.63ms - 15.40msunsure 🔍
-3% - +5%
-0.42ms - +0.74ms		-unsure 🔍
-3% - +5%
-0.43ms - +0.69ms
preact-hooks14.48ms - 15.28msunsure 🔍
-4% - +4%
-0.56ms - +0.62ms		unsure 🔍
-5% - +3%
-0.69ms - +0.43ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master23.09ms - 24.09ms-unsure 🔍
-4% - +2%
-0.99ms - +0.36ms		unsure 🔍
-2% - +4%
-0.56ms - +0.86ms
preact-local23.45ms - 24.36msunsure 🔍
-2% - +4%
-0.36ms - +0.99ms		-unsure 🔍
-1% - +5%
-0.21ms - +1.15ms
preact-hooks22.93ms - 23.94msunsure 🔍
-4% - +2%
-0.86ms - +0.56ms		unsure 🔍
-5% - +1%
-1.15ms - +0.21ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.96ms - 4.97ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.03ms
preact-local4.97ms - 4.97msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.99ms - 4.99msslower ❌
0% - 1%
0.01ms - 0.03ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master2.91ms - 2.94ms-unsure 🔍
-1% - +1%
-0.03ms - +0.02ms		faster ✔
4% - 5%
0.12ms - 0.16ms
preact-local2.91ms - 2.95msunsure 🔍
-1% - +1%
-0.02ms - +0.03ms		-faster ✔
4% - 5%
0.12ms - 0.16ms
preact-hooks3.05ms - 3.08msslower ❌
4% - 6%
0.12ms - 0.16ms		slower ❌
4% - 5%
0.12ms - 0.16ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.14ms - 1.14ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.01ms - 0.01ms
preact-local1.14ms - 1.14msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.01ms - 0.01ms
preact-hooks1.16ms - 1.16msslower ❌
1% - 1%
0.01ms - 0.01ms		slower ❌
1% - 1%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master54.95ms - 56.53ms-unsure 🔍
-4% - +1%
-2.11ms - +0.55ms		unsure 🔍
-4% - +1%
-2.00ms - +0.31ms
preact-local55.46ms - 57.59msunsure 🔍
-1% - +4%
-0.55ms - +2.11ms		-unsure 🔍
-3% - +2%
-1.42ms - +1.29ms
preact-hooks55.74ms - 57.43msunsure 🔍
-1% - +4%
-0.31ms - +2.00ms		unsure 🔍
-2% - +3%
-1.29ms - +1.42ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.43ms - 1.43ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.03ms - 0.03ms
preact-local1.43ms - 1.43msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.03ms - 0.03ms
preact-hooks1.46ms - 1.46msslower ❌
2% - 2%
0.03ms - 0.03ms		slower ❌
2% - 2%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited

Size Change: 0 B

Total Size: 52.9 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.81 kB 0 B
compat/dist/compat.module.js 3.75 kB 0 B
compat/dist/compat.umd.js 3.87 kB 0 B
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
dist/preact.js 4.06 kB 0 B
dist/preact.min.js 4.08 kB 0 B
dist/preact.min.module.js 4.08 kB 0 B
dist/preact.min.umd.js 4.11 kB 0 B
dist/preact.module.js 4.07 kB 0 B
dist/preact.umd.js 4.12 kB 0 B
hooks/dist/hooks.js 1.49 kB 0 B
hooks/dist/hooks.module.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.57 kB 0 B
jsx-runtime/dist/jsxRuntime.js 358 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 324 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 439 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@andrewiggins andrewiggins mentioned this pull request Oct 25, 2022
Merged
@andrewiggins
Copy link
Member Author

Hmm it appears that a new feature of npm v7 or v8 is that prepare scripts of locally installed dependencies are run when they are installed. That doesn't work for us here cuz I don't do an install at the repo root for each bench and instead build the repo once in the prepare job and copy the build output to each bench job (often it's much faster, 1-5s vs 30s for install).

Need to noodle on this some more. Maybe it's just easier to run the install & build in each bench :/ Could also explore installing directly from the tarball produced by the prepare job...

@marvinhagemeister
Copy link
Member

@andrewiggins That's a bummer. Just grabbing the tarball sounds like the easiest approach for now.

@andrewiggins andrewiggins merged commit 34a8c16 into master Oct 27, 2022
@andrewiggins andrewiggins deleted the upgrade-workflows branch October 27, 2022 18:37
@marvinhagemeister marvinhagemeister mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewiggins @coveralls @marvinhagemeister @JoviDeCroock