Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bench dependencies #3778

Merged
merged 1 commit into from Oct 27, 2022
Merged

Upgrade bench dependencies #3778

merged 1 commit into from Oct 27, 2022

Conversation

andrewiggins
Copy link
Member

  • Change how we specify paths in tachometer configs to match new tachometer behavior
  • Update imports for new ESM deps
  • Fix some linting issues in bench scripts

@coveralls
Copy link

coveralls commented Oct 25, 2022 •
edited

Coverage Status

Coverage remained the same at 99.531% when pulling fbabbbb on upgrade-bench-deps into 34a8c16 on master.

@andrewiggins
Copy link
Member Author

Let's wait for #3777 and running everything on Node16 before merging this one

@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -18% - +2% (-24.00ms - +2.62ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +4% (-1.92ms - +2.24ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-8.43ms - +6.86ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -4% - +2% (-1.05ms - +0.39ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +0% (-1.75ms - +0.26ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -4% - +4% (-1.29ms - +1.38ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -1% - +3% (-0.04ms - +0.10ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -2% - +1% (-1.39ms - +0.59ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +15% (-0.00ms - +0.64ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -6% - +1% (-0.89ms - +0.09ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master120.13ms - 136.60ms-unsure 🔍
-3% - +21%
-2.62ms - +24.00ms		unsure 🔍
-4% - +20%
-4.34ms - +23.36ms
preact-local107.21ms - 128.13msunsure 🔍
-18% - +2%
-24.00ms - +2.62ms		-unsure 🔍
-14% - +12%
-16.46ms - +14.10ms
preact-hooks107.72ms - 130.00msunsure 🔍
-18% - +3%
-23.36ms - +4.34ms		unsure 🔍
-12% - +14%
-14.10ms - +16.46ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.07ms - 4.46ms-unsure 🔍
-14% - -0%
-0.64ms - +0.00ms		faster ✔
0% - 14%
0.01ms - 0.65ms
preact-local4.32ms - 4.83msunsure 🔍
-0% - +15%
-0.00ms - +0.64ms		-unsure 🔍
-8% - +8%
-0.37ms - +0.35ms
preact-hooks4.34ms - 4.85msunsure 🔍
-0% - +15%
+0.01ms - +0.65ms		unsure 🔍
-8% - +8%
-0.35ms - +0.37ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.19ms - 1.29ms-unsure 🔍
-5% - +7%
-0.07ms - +0.08ms		unsure 🔍
-1% - +9%
-0.02ms - +0.10ms
preact-local1.17ms - 1.29msunsure 🔍
-7% - +5%
-0.08ms - +0.07ms		-unsure 🔍
-3% - +9%
-0.03ms - +0.10ms
preact-hooks1.16ms - 1.23msunsure 🔍
-8% - +1%
-0.10ms - +0.02ms		unsure 🔍
-8% - +3%
-0.10ms - +0.03ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.83ms - 1.33ms-unsure 🔍
-34% - +20%
-0.40ms - +0.24ms		unsure 🔍
-16% - +47%
-0.14ms - +0.43ms
preact-local0.95ms - 1.37msunsure 🔍
-24% - +38%
-0.24ms - +0.40ms		-unsure 🔍
-5% - +53%
-0.03ms - +0.47ms
preact-hooks0.79ms - 1.08msunsure 🔍
-37% - +10%
-0.43ms - +0.14ms		unsure 🔍
-38% - -0%
-0.47ms - +0.03ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.48ms - 0.54ms-unsure 🔍
-16% - +2%
-0.09ms - +0.01ms		unsure 🔍
-5% - +8%
-0.03ms - +0.04ms
preact-local0.50ms - 0.59msunsure 🔍
-3% - +18%
-0.01ms - +0.09ms		-unsure 🔍
-0% - +18%
+0.00ms - +0.09ms
preact-hooks0.48ms - 0.52msunsure 🔍
-8% - +5%
-0.04ms - +0.03ms		faster ✔
1% - 16%
0.00ms - 0.09ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.58ms - 1.44ms-unsure 🔍
-51% - +95%
-0.37ms - +0.74ms		faster ✔
15% - 74%
0.09ms - 1.53ms
preact-local0.48ms - 1.18msunsure 🔍
-67% - +31%
-0.74ms - +0.37ms		-faster ✔
30% - 79%
0.32ms - 1.67ms
preact-hooks1.25ms - 2.40msunsure 🔍
-16% - +175%
+0.09ms - +1.53ms		slower ❌
4% - 236%
0.32ms - 1.67ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.37ms - 0.45ms-unsure 🔍
-7% - +22%
-0.03ms - +0.08ms		unsure 🔍
-15% - +9%
-0.07ms - +0.04ms
preact-local0.34ms - 0.41msunsure 🔍
-20% - +6%
-0.08ms - +0.03ms		-unsure 🔍
-21% - +1%
-0.09ms - +0.01ms
preact-hooks0.39ms - 0.45msunsure 🔍
-9% - +16%
-0.04ms - +0.07ms		unsure 🔍
-2% - +25%
-0.01ms - +0.09ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.38ms - 0.46ms-unsure 🔍
-9% - +22%
-0.03ms - +0.09ms		unsure 🔍
-13% - +11%
-0.06ms - +0.05ms
preact-local0.35ms - 0.44msunsure 🔍
-20% - +7%
-0.09ms - +0.03ms		-unsure 🔍
-20% - +6%
-0.09ms - +0.03ms
preact-hooks0.39ms - 0.46msunsure 🔍
-12% - +14%
-0.05ms - +0.06ms		unsure 🔍
-7% - +23%
-0.03ms - +0.09ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master48.72ms - 51.43ms-unsure 🔍
-4% - +4%
-2.24ms - +1.92ms		unsure 🔍
-4% - +3%
-2.19ms - +1.58ms
preact-local48.66ms - 51.81msunsure 🔍
-4% - +4%
-1.92ms - +2.24ms		-unsure 🔍
-4% - +4%
-2.20ms - +1.91ms
preact-hooks49.07ms - 51.69msunsure 🔍
-3% - +4%
-1.58ms - +2.19ms		unsure 🔍
-4% - +4%
-1.91ms - +2.20ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.78ms - 3.79ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
0% - 1%
0.01ms - 0.02ms
preact-local3.78ms - 3.79msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.01ms - 0.02ms
preact-hooks3.80ms - 3.80msslower ❌
0% - 1%
0.01ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1168.47ms - 1181.48ms-unsure 🔍
-1% - +1%
-6.86ms - +8.43ms		unsure 🔍
-1% - +0%
-12.34ms - +4.38ms
preact-local1170.16ms - 1178.21msunsure 🔍
-1% - +1%
-8.43ms - +6.86ms		-unsure 🔍
-1% - +0%
-11.38ms - +1.85ms
preact-hooks1173.70ms - 1184.21msunsure 🔍
-0% - +1%
-4.38ms - +12.34ms		unsure 🔍
-0% - +1%
-1.85ms - +11.38ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.84ms - 25.84ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local25.84ms - 25.84msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks25.86ms - 25.86msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master23.08ms - 24.09ms-unsure 🔍
-2% - +5%
-0.39ms - +1.05ms		unsure 🔍
-1% - +5%
-0.24ms - +1.08ms
preact-local22.74ms - 23.77msunsure 🔍
-4% - +2%
-1.05ms - +0.39ms		-unsure 🔍
-3% - +3%
-0.58ms - +0.75ms
preact-hooks22.75ms - 23.59msunsure 🔍
-5% - +1%
-1.08ms - +0.24ms		unsure 🔍
-3% - +2%
-0.75ms - +0.58ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.93ms - 1.93ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.93ms - 1.93msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.95ms - 1.95msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master118.02ms - 119.72ms-unsure 🔍
-0% - +1%
-0.26ms - +1.75ms		unsure 🔍
-1% - +1%
-1.30ms - +1.01ms
preact-local117.60ms - 118.65msunsure 🔍
-1% - +0%
-1.75ms - +0.26ms		-unsure 🔍
-2% - +0%
-1.82ms - +0.05ms
preact-hooks118.24ms - 119.79msunsure 🔍
-1% - +1%
-1.01ms - +1.30ms		unsure 🔍
-0% - +2%
-0.05ms - +1.82ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master15.27ms - 15.91ms-unsure 🔍
-1% - +6%
-0.09ms - +0.89ms		unsure 🔍
-3% - +3%
-0.43ms - +0.52ms
preact-local14.81ms - 15.56msunsure 🔍
-6% - +1%
-0.89ms - +0.09ms		-unsure 🔍
-6% - +1%
-0.87ms - +0.15ms
preact-hooks15.20ms - 15.90msunsure 🔍
-3% - +3%
-0.52ms - +0.43ms		unsure 🔍
-1% - +6%
-0.15ms - +0.87ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master33.17ms - 35.28ms-unsure 🔍
-4% - +4%
-1.38ms - +1.29ms		unsure 🔍
-4% - +3%
-1.51ms - +0.98ms
preact-local33.45ms - 35.10msunsure 🔍
-4% - +4%
-1.29ms - +1.38ms		-unsure 🔍
-4% - +2%
-1.28ms - +0.84ms
preact-hooks33.83ms - 35.16msunsure 🔍
-3% - +4%
-0.98ms - +1.51ms		unsure 🔍
-2% - +4%
-0.84ms - +1.28ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.97ms - 4.97ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms		unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-local4.96ms - 4.97msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-hooks4.98ms - 4.99msunsure 🔍
+0% - +0%
+0.01ms - +0.02ms		unsure 🔍
+0% - +0%
+0.01ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.47ms - 3.57ms-unsure 🔍
-3% - +1%
-0.10ms - +0.04ms		faster ✔
3% - 7%
0.12ms - 0.26ms
preact-local3.50ms - 3.60msunsure 🔍
-1% - +3%
-0.04ms - +0.10ms		-faster ✔
2% - 6%
0.09ms - 0.23ms
preact-hooks3.66ms - 3.77msslower ❌
3% - 8%
0.12ms - 0.26ms		slower ❌
2% - 7%
0.09ms - 0.23ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.14ms - 1.14ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.01ms - 0.01ms
preact-local1.14ms - 1.14msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.01ms - 0.01ms
preact-hooks1.16ms - 1.16msslower ❌
1% - 1%
0.01ms - 0.01ms		slower ❌
1% - 1%
0.01ms - 0.01ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master70.22ms - 71.82ms-unsure 🔍
-1% - +2%
-0.59ms - +1.39ms		faster ✔
1% - 4%
0.41ms - 2.90ms
preact-local70.04ms - 71.20msunsure 🔍
-2% - +1%
-1.39ms - +0.59ms		-faster ✔
1% - 4%
0.93ms - 3.17ms
preact-hooks71.71ms - 73.63msslower ❌
1% - 4%
0.41ms - 2.90ms		slower ❌
1% - 5%
0.93ms - 3.17ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.43ms - 1.43ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.03ms - 0.03ms
preact-local1.43ms - 1.43msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.03ms - 0.03ms
preact-hooks1.46ms - 1.46msslower ❌
2% - 2%
0.03ms - 0.03ms		slower ❌
2% - 2%
0.03ms - 0.03ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

Size Change: 0 B

Total Size: 52.9 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.81 kB 0 B
compat/dist/compat.module.js 3.75 kB 0 B
compat/dist/compat.umd.js 3.87 kB 0 B
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
dist/preact.js 4.06 kB 0 B
dist/preact.min.js 4.08 kB 0 B
dist/preact.min.module.js 4.08 kB 0 B
dist/preact.min.umd.js 4.11 kB 0 B
dist/preact.module.js 4.07 kB 0 B
dist/preact.umd.js 4.12 kB 0 B
hooks/dist/hooks.js 1.49 kB 0 B
hooks/dist/hooks.module.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.57 kB 0 B
jsx-runtime/dist/jsxRuntime.js 358 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 324 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 439 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@andrewiggins andrewiggins merged commit 05d91ad into master Oct 27, 2022
@andrewiggins andrewiggins deleted the upgrade-bench-deps branch October 27, 2022 18:52
@marvinhagemeister marvinhagemeister mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewiggins @coveralls @marvinhagemeister @JoviDeCroock