Server compat should have a default export #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, as you can see with your client.js https://github.com/preactjs/preact/blob/master/compat/client.mjs, you need a default export to be imported with Do you prefer I add some tests to make it sure both imports work as expected ? |
|
ANother example, i'm working with draft-convert and there is this kind of error too:
In order to fix this, I need a default export |
rschristian
reviewed
Jun 15, 2023
MikaFima
force-pushed
the
compat-server-default-export
branch
from
348d5f2
to
65f73f8
Compare
|
Is that okay for you ? |
rschristian
reviewed
Jun 20, 2023
compat/server.browser.js
Outdated
| @@ -1,4 +1,11 @@ | |||
| import { renderToString as preactRenderToString } from 'preact-render-to-string'; | |||
There was a problem hiding this comment.
nit: No need for the as, just keep it as renderToString
rschristian
reviewed
Jun 20, 2023
compat/server.mjs
Outdated
| @@ -1,4 +1,11 @@ | |||
| import { renderToString as preactRenderToString } from 'preact-render-to-string'; | |||
rschristian
approved these changes
Jun 20, 2023
MikaFima
force-pushed
the
compat-server-default-export
branch
from
65f73f8
to
90d618c
Compare
JoviDeCroock
approved these changes
Jun 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi preact,
For now the use of preact/compat do not allow to use
import ReactDOM from 'react-dom/server', as it will fail with an error:This PR is here to allow it, without breaking the classical use
import {renderToStaticMarkup} from 'react-dom/server'