Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4109 #4110

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Fix #4109 #4110

merged 2 commits into from
Aug 20, 2023

Conversation

Popovkov57
Copy link
Contributor

@Popovkov57 Popovkov57 commented Aug 20, 2023 •
edited by marvinhagemeister

Hi

I replaced for-of loop with standard for loop in debug.js to fixe the issue 4109.

Best regards.

Fixes #4109

marvinhagemeister
marvinhagemeister approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for making a PR for this 👍

@coveralls
Copy link

Coverage Status

coverage: 99.562% (-0.001%) from 99.563% when pulling 204ab5d on Popovkov57:main into 0afad8c on preactjs:main.

@marvinhagemeister marvinhagemeister merged commit 0ede0c3 into preactjs:main Aug 20, 2023
3 checks passed
@JoviDeCroock JoviDeCroock mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace for-of loop with standard for loop
3 participants
@Popovkov57 @coveralls @marvinhagemeister