feat: Add SetStateAction & PropsWithoutRef types to compat
#4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4131
Closes #4124
React's
SetStateActionvs ourStateUpdater. I elected to replaceStateUpdater's export as it was never a type offered by React -- I believe this was simply a mistake that we missed, it always should've been re-exported asSetStateAction. If the breaking change is a concern I'll be happy to revert but I don't imagine it's seeing any use.React's
PropsWithoutRefis a bit more complex than what we've been using (as it's used forforwardRef's types), but seeing as how we have no issues in our tracker as far as I can tell, I chose to keep using our (perhaps naive) version for now. Can change if desired though.