Add missing native attribute JSX types #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
requested review from
developit,
andrewiggins and
JoviDeCroock
marvinhagemeister
changed the title
marvinhagemeister
force-pushed
the
add-html-types
branch
from
86a2759
to
aee0741
Compare
JoviDeCroock
approved these changes
Sep 24, 2023
marvinhagemeister
force-pushed
the
add-html-types
branch
from
aee0741
to
4def55e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our JSX types we have often both the react camelCase attribute name as well as the lower cased DOM name. But that list was incomplete and only some DOM types were present. So I went through our JSX types and added the missing DOM casings. Interestingly the SVG attribute list is a bit inconsistent when it comes to casing and some attributes only exist in camelCase.